* bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation
@ 2014-11-17 16:11 Magnus Henoch
2016-02-23 12:00 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Magnus Henoch @ 2014-11-17 16:11 UTC (permalink / raw)
To: 19081
[-- Attachment #1: Type: text/plain, Size: 392 bytes --]
Severity: minor
Tags: patch
The input method polish-slash is the only input method in latin-pre.el
that passes t as the KBD-TRANSLATE argument to quail-define-package. I
think it shouldn't do that, because it doesn't represent an alternative
keyboard layout; it's just a thin layer over whatever keyboard layout is
currently in use.
This patch changes the KBD-TRANSLATE argument to nil:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 517 bytes --]
diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
index 6202b89..b3a7591 100644
--- a/lisp/leim/quail/latin-pre.el
+++ b/lisp/leim/quail/latin-pre.el
@@ -707,7 +707,7 @@ Key translation rules are:
"polish-slash" "Polish" "PL>" nil
"Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
For example, the character named `aogonek' is obtained by `/a'."
- nil t t t nil nil nil nil nil nil t)
+ nil t t nil nil nil nil nil nil nil t)
(quail-define-rules
("//" ?/)
[-- Attachment #3: Type: text/plain, Size: 17 bytes --]
Regards,
Magnus
^ permalink raw reply related [flat|nested] 5+ messages in thread
* bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation
2014-11-17 16:11 bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation Magnus Henoch
@ 2016-02-23 12:00 ` Lars Ingebrigtsen
2016-02-23 16:26 ` Eli Zaretskii
2016-02-24 13:43 ` handa
0 siblings, 2 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-23 12:00 UTC (permalink / raw)
To: Magnus Henoch; +Cc: 19081
Magnus Henoch <magnus.henoch@gmail.com> writes:
> The input method polish-slash is the only input method in latin-pre.el
> that passes t as the KBD-TRANSLATE argument to quail-define-package. I
> think it shouldn't do that, because it doesn't represent an alternative
> keyboard layout; it's just a thin layer over whatever keyboard layout is
> currently in use.
>
> This patch changes the KBD-TRANSLATE argument to nil:
>
> diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
> index 6202b89..b3a7591 100644
> --- a/lisp/leim/quail/latin-pre.el
> +++ b/lisp/leim/quail/latin-pre.el
> @@ -707,7 +707,7 @@ Key translation rules are:
> "polish-slash" "Polish" "PL>" nil
> "Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
> For example, the character named `aogonek' is obtained by `/a'."
> - nil t t t nil nil nil nil nil nil t)
> + nil t t nil nil nil nil nil nil nil t)
I think this sounds reasonable, but I'm not familiar with the quail
functions at all. Could somebody have a peek at this?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation
2016-02-23 12:00 ` Lars Ingebrigtsen
@ 2016-02-23 16:26 ` Eli Zaretskii
2016-02-24 13:43 ` handa
1 sibling, 0 replies; 5+ messages in thread
From: Eli Zaretskii @ 2016-02-23 16:26 UTC (permalink / raw)
To: Lars Ingebrigtsen, Kenichi Handa; +Cc: 19081, magnus.henoch
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 23 Feb 2016 23:00:28 +1100
> Cc: 19081@debbugs.gnu.org
>
> Magnus Henoch <magnus.henoch@gmail.com> writes:
>
> > The input method polish-slash is the only input method in latin-pre.el
> > that passes t as the KBD-TRANSLATE argument to quail-define-package. I
> > think it shouldn't do that, because it doesn't represent an alternative
> > keyboard layout; it's just a thin layer over whatever keyboard layout is
> > currently in use.
> >
> > This patch changes the KBD-TRANSLATE argument to nil:
> >
> > diff --git a/lisp/leim/quail/latin-pre.el b/lisp/leim/quail/latin-pre.el
> > index 6202b89..b3a7591 100644
> > --- a/lisp/leim/quail/latin-pre.el
> > +++ b/lisp/leim/quail/latin-pre.el
> > @@ -707,7 +707,7 @@ Key translation rules are:
> > "polish-slash" "Polish" "PL>" nil
> > "Polish diacritics and slash character are input as `/[acelnosxzACELNOSXZ/]'.
> > For example, the character named `aogonek' is obtained by `/a'."
> > - nil t t t nil nil nil nil nil nil t)
> > + nil t t nil nil nil nil nil nil nil t)
>
> I think this sounds reasonable, but I'm not familiar with the quail
> functions at all. Could somebody have a peek at this?
I hope Handa-san (CC'ed) could comment on this.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation
2016-02-23 12:00 ` Lars Ingebrigtsen
2016-02-23 16:26 ` Eli Zaretskii
@ 2016-02-24 13:43 ` handa
2016-02-25 5:40 ` Lars Ingebrigtsen
1 sibling, 1 reply; 5+ messages in thread
From: handa @ 2016-02-24 13:43 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 19081, magnus.henoch
In article <87lh6bprfn.fsf@gnus.org>, Lars Ingebrigtsen <larsi@gnus.org> writes:
> Magnus Henoch <magnus.henoch@gmail.com> writes:
> > The input method polish-slash is the only input method in latin-pre.el
> > that passes t as the KBD-TRANSLATE argument to quail-define-package. I
> > think it shouldn't do that, because it doesn't represent an alternative
> > keyboard layout; it's just a thin layer over whatever keyboard layout is
> > currently in use.
You are right. The docstring of polish-slash clearly says that typing
"/a" should produce "ą" whereever "/" and "a" are located on a keyboard.
So KBD-TRANSLATE should be nil.
---
K. Handa
handa@gnu.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation
2016-02-24 13:43 ` handa
@ 2016-02-25 5:40 ` Lars Ingebrigtsen
0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2016-02-25 5:40 UTC (permalink / raw)
To: handa; +Cc: 19081, magnus.henoch
handa <handa@gnu.org> writes:
> In article <87lh6bprfn.fsf@gnus.org>, Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Magnus Henoch <magnus.henoch@gmail.com> writes:
>> > The input method polish-slash is the only input method in latin-pre.el
>> > that passes t as the KBD-TRANSLATE argument to quail-define-package. I
>> > think it shouldn't do that, because it doesn't represent an alternative
>> > keyboard layout; it's just a thin layer over whatever keyboard layout is
>> > currently in use.
>
> You are right. The docstring of polish-slash clearly says that typing
> "/a" should produce "ą" whereever "/" and "a" are located on a keyboard.
> So KBD-TRANSLATE should be nil.
Thanks; I've now applied the patch.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-25 5:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 16:11 bug#19081: 24.4.50; Input method polish-slash should not use keyboard translation Magnus Henoch
2016-02-23 12:00 ` Lars Ingebrigtsen
2016-02-23 16:26 ` Eli Zaretskii
2016-02-24 13:43 ` handa
2016-02-25 5:40 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).