From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23074: 25.1.50; X11: `use-fancy-splash-screens-p` erroneously returns nil. Date: Tue, 22 Mar 2016 18:07:18 +0200 Message-ID: <834mby5weh.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1458662908 7752 80.91.229.3 (22 Mar 2016 16:08:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Mar 2016 16:08:28 +0000 (UTC) Cc: 23074@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 22 17:08:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aiOqs-0004Tq-4Q for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Mar 2016 17:08:14 +0100 Original-Received: from localhost ([::1]:38202 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOqr-0007Na-B9 for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Mar 2016 12:08:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOqj-0007ML-LU for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 12:08:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiOqg-0004tD-G8 for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 12:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34822) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOqg-0004t7-Cd for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 12:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aiOqg-0008Og-79 for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 12:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Mar 2016 16:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23074 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23074-submit@debbugs.gnu.org id=B23074.145866287032258 (code B ref 23074); Tue, 22 Mar 2016 16:08:02 +0000 Original-Received: (at 23074) by debbugs.gnu.org; 22 Mar 2016 16:07:50 +0000 Original-Received: from localhost ([127.0.0.1]:60182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiOqT-0008OE-Ln for submit@debbugs.gnu.org; Tue, 22 Mar 2016 12:07:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiOqR-0008O0-IH for 23074@debbugs.gnu.org; Tue, 22 Mar 2016 12:07:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiOqJ-0004oE-7Z for 23074@debbugs.gnu.org; Tue, 22 Mar 2016 12:07:42 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiOqJ-0004o9-42; Tue, 22 Mar 2016 12:07:39 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4067 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aiOqH-00053n-48; Tue, 22 Mar 2016 12:07:38 -0400 In-reply-to: (message from Keith David Bershatsky on Mon, 21 Mar 2016 18:03:21 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115329 Archived-At: > Date: Mon, 21 Mar 2016 18:03:21 -0700 > From: Keith David Bershatsky > Cc: 23074@debbugs.gnu.org > > The following test was performed with no toolkit -- i.e., --with-x > --with-x-toolkit=no --with-ns=no > > M-: (frame-height) RET > > Evaluating the above gives me a value of 35. > > M-: (image-size (create-image (fancy-splash-image-file))) RET > > Evaluating the above gives me a value of: (41.625 . 15.533333333333333) > > The value for `fancy-splash-image-file` is: "splash.svg" Then, with the code you modified in startup.el, you do succeed to get the fancy splash image, but the text below it is only partially visible, right? IOW, one or two (maybe even 3) last lines are not visible? This is exactly what the test was trying to avoid. So if we go with your proposal, it is not clear why we should insist on some minimal frame height at all. (Or maybe you don't have auto-save file lists in your home directory, in which case your startup screen shows 2 lines less than it does on my system, and you are not aware of the problem for that reason.) I think the correct solution will be to increase the default frame size by 1 or maybe even 2 lines. Because on my system, the last line is only partially visible, so the calculation in use-fancy-splash-screens-p is slightly inaccurate (because it is off-by-one -- we need to subtract 2 from the frame height, not 1).