From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23871: 25.1.50; Undo unexpectedly leads to blank buffer Date: Sun, 03 Jul 2016 06:31:18 +0300 Message-ID: <834m87s8hl.fsf@gnu.org> References: <83h9cavdgj.fsf@gnu.org> <87poqyy2tc.fsf@metalevel.at> <87vb0qqrkz.fsf@russet.org.uk> <87h9c9zx75.fsf@metalevel.at> <834m89vmyv.fsf@gnu.org> <878txlsbdb.fsf@russet.org.uk> <87furtccdv.fsf@metalevel.at> <877fd5q9te.fsf@russet.org.uk> <83bn2gtruk.fsf@gnu.org> <87k2h37pvb.fsf@russet.org.uk> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1467516745 18733 80.91.229.3 (3 Jul 2016 03:32:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Jul 2016 03:32:25 +0000 (UTC) Cc: 23871@debbugs.gnu.org, triska@metalevel.at To: phillip.lord@russet.org.uk (Phillip Lord) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 03 05:32:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bJY8j-0003HW-57 for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jul 2016 05:32:13 +0200 Original-Received: from localhost ([::1]:41051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJY8i-00015Y-EY for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jul 2016 23:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJY8c-00015Q-K7 for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 23:32:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJY8Y-0007k4-FD for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 23:32:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJY8Y-0007k0-BN for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 23:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bJY8Y-0006vn-7q for bug-gnu-emacs@gnu.org; Sat, 02 Jul 2016 23:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jul 2016 03:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23871 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23871-submit@debbugs.gnu.org id=B23871.146751670526620 (code B ref 23871); Sun, 03 Jul 2016 03:32:02 +0000 Original-Received: (at 23871) by debbugs.gnu.org; 3 Jul 2016 03:31:45 +0000 Original-Received: from localhost ([127.0.0.1]:35031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJY8G-0006vH-Kp for submit@debbugs.gnu.org; Sat, 02 Jul 2016 23:31:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bJY8D-0006v4-76 for 23871@debbugs.gnu.org; Sat, 02 Jul 2016 23:31:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bJY84-0007iy-MU for 23871@debbugs.gnu.org; Sat, 02 Jul 2016 23:31:35 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bJY84-0007it-Iu; Sat, 02 Jul 2016 23:31:32 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3927 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bJY82-0003Ss-LA; Sat, 02 Jul 2016 23:31:31 -0400 In-reply-to: <87k2h37pvb.fsf@russet.org.uk> (phillip.lord@russet.org.uk) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120314 Archived-At: > From: phillip.lord@russet.org.uk (Phillip Lord) > Cc: triska@metalevel.at, 23871@debbugs.gnu.org > Date: Sat, 02 Jul 2016 21:21:28 +0100 > > > The problem, AFAIU, is in point movements _during_ eval-defun: they > > seem to not be recorded in buffer-undo-list. The undo list I get > > after C-M-x is this: > > > > (nil (117 . 122) (t 22391 27551 0 0)) > > > > So, I don't think this is a regression caused by my patch at all. It is > an bug that has been there since I altered undo.c last year. > > The problem was caused because of undo only records point after a > boundary (or the first element). I'd changed things during slightly when > I update undo.c so that the timestamp list got added before checking > whether I was at a boundary, hence blocking addition of the point > restoration information. > > This is why I found the problem so erratic to replicate; it only occurs > immediately the first change to a buffer. > > I believe the following patch addresses the issue. Seems like this is still not the final patch, so I guess we will need to wait for the right one. It should go to the emacs-25 branch, which probably means one more pretest, sigh. Thanks.