From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23937: 25.0.95; Search functions doc fixes/improvements Date: Tue, 12 Jul 2016 08:03:25 +0300 Message-ID: <834m7vcusi.fsf@gnu.org> References: <87d1ml8ic1.fsf@gmx.net> <83lh18cib0.fsf@gnu.org> <871t2z262g.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468299866 21115 80.91.229.3 (12 Jul 2016 05:04:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 12 Jul 2016 05:04:26 +0000 (UTC) Cc: 23937@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 12 07:04:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bMpri-0007Jx-Le for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 07:04:14 +0200 Original-Received: from localhost ([::1]:37414 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMprh-000863-Ni for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Jul 2016 01:04:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMprX-00085f-Oz for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 01:04:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMprW-0001XH-MJ for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 01:04:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMprW-0001XD-It for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 01:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bMprW-0004AW-7g for bug-gnu-emacs@gnu.org; Tue, 12 Jul 2016 01:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Jul 2016 05:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23937 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23937-submit@debbugs.gnu.org id=B23937.146829983416009 (code B ref 23937); Tue, 12 Jul 2016 05:04:02 +0000 Original-Received: (at 23937) by debbugs.gnu.org; 12 Jul 2016 05:03:54 +0000 Original-Received: from localhost ([127.0.0.1]:47444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMprO-0004A9-7y for submit@debbugs.gnu.org; Tue, 12 Jul 2016 01:03:54 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bMprM-00049r-R2 for 23937@debbugs.gnu.org; Tue, 12 Jul 2016 01:03:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bMprD-0001S0-Nr for 23937@debbugs.gnu.org; Tue, 12 Jul 2016 01:03:47 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bMprD-0001Rv-Ka; Tue, 12 Jul 2016 01:03:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4386 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bMprB-0007JU-Te; Tue, 12 Jul 2016 01:03:42 -0400 In-reply-to: <871t2z262g.fsf@gmx.net> (message from Stephen Berman on Mon, 11 Jul 2016 23:55:19 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120888 Archived-At: > From: Stephen Berman > Cc: 23937@debbugs.gnu.org > Date: Mon, 11 Jul 2016 23:55:19 +0200 > > >> @@ -2247,14 +2252,15 @@ DEFUN ("posix-search-backward", Fposix_search_backward, Sposix_search_backward, > >> "sPosix search backward: ", > >> doc: /* Search backward from point for match for regular expression REGEXP. > >> Find the longest match in accord with Posix regular expression rules. > >> -Set point to the beginning of the match, and return point. > >> -The match found is the one starting last in the buffer > >> -and yet ending before the origin of the search. > >> +Set point to the beginning of the occurrence found, and return point. > > > > The 2nd and 3rd lines you removed seem to provide valuable information > > which is now gone, no? > > I removed them because I thought they were (i) partly redundant: the > first words of the doc string, "Search backward from point", already > imply that the match ends before that position, since otherwise it > wouldn't be a search backward I don't agree, I think this part is not clear unless explicitly described. I frequently find myself wondering about this when I need to code a loop that uses these functions. > and (ii) partly inaccurate: saying the > match found is the last one in the buffer before the starting point is > only true when COUNT is 1 (or nil) Then let's make it more accurate, but I don't think removing that is TRT. In particular, there's nothing wrong with describing what happens with COUNT = 1 if the clarity is required only in that case. > I assume it's ok to push the changes to emacs-25? Yes. (The comment about COUNT = 0 was a teaser, don't worry about that.)