From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Tue, 19 Jul 2016 19:13:21 +0300 Message-ID: <834m7l1u8u.fsf@gnu.org> References: <87vb066ejv.fsf@linaro.org> <8360s67qcp.fsf@gnu.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1468944927 11796 80.91.229.3 (19 Jul 2016 16:15:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 19 Jul 2016 16:15:27 +0000 (UTC) Cc: 23917@debbugs.gnu.org, rpluim@gmail.com, jwiegley@gmail.com, alex.bennee@linaro.org, nljlistbox2@gmail.com To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 19 18:15:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPXft-000461-IJ for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 18:15:13 +0200 Original-Received: from localhost ([::1]:57083 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXfs-0000wT-NC for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Jul 2016 12:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXfm-0000ui-6j for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 12:15:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPXfi-0000Sv-CA for bug-gnu-emacs@gnu.org; Tue, 19 Jul 2016 12:15:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXfi-0000Sr-84; Tue, 19 Jul 2016 12:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bPXfi-0002u8-1k; Tue, 19 Jul 2016 12:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Tue, 19 Jul 2016 16:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146894484311084 (code B ref 23917); Tue, 19 Jul 2016 16:15:01 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 19 Jul 2016 16:14:03 +0000 Original-Received: from localhost ([127.0.0.1]:57503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPXel-0002si-8w for submit@debbugs.gnu.org; Tue, 19 Jul 2016 12:14:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPXek-0002s7-0m for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 12:14:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPXeZ-0000GC-J9 for 23917@debbugs.gnu.org; Tue, 19 Jul 2016 12:13:56 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPXeT-0000Ev-Eq; Tue, 19 Jul 2016 12:13:45 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3531 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bPXeO-0004dL-Pv; Tue, 19 Jul 2016 12:13:43 -0400 In-reply-to: (message from Stefan Monnier on Tue, 19 Jul 2016 12:03:51 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121268 Archived-At: > From: Stefan Monnier > Cc: rpluim@gmail.com, 23917@debbugs.gnu.org, alex.bennee@linaro.org, jwiegley@gmail.com, nljlistbox2@gmail.com > Date: Tue, 19 Jul 2016 12:03:51 -0400 > > I guess the next best thing is: > - copy search_regs.start and search_regs.end before calling replace_range. > - use that copy when adjusting the match data. > Or equivalently, use save-match-data. IOW go back to your original patch. > Duh! Do we care that using save-match-data in every call to replace-match might mean a performance hit? If it will, then this will again punish most of the users for the benefit of those few who (1) have buffer-modification hooks, and (2) those hooks call save-match-data.