unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: user42_kevin@yahoo.com.au, 26396@debbugs.gnu.org
Subject: bug#26396: 25.1; char-displayable-p on a latin1 tty
Date: Sat, 15 Apr 2017 11:48:15 +0300	[thread overview]
Message-ID: <834lxqgipc.fsf@gnu.org> (raw)
In-Reply-To: <24bd0681-08d5-137f-29df-715eefddf2ae@cs.ucla.edu> (message from Paul Eggert on Fri, 14 Apr 2017 11:56:32 -0700)

> > Suppose we only wanted to use this feature for UTF-8 locales.
> > Assuming that the OS takes care of putting the console in UTF-8 mode,
> > we don't need any changes in Emacs, since Emacs already sends UTF-8
> > sequences to the screen driver.  As the Linux console only supports
> > the BMP, we could then simply amend the code of char-displayable-p to
> > check whether a character is within the BMP, when the terminal is the
> > Linux console.  Do you agree with this conclusion?
> 
> No, because a character is displayable only if it's in that set of 
> at-most-512 characters.
> 
> > OTOH, now I'm not sure I understand the need for terminal_glyph_code.
> > What does it do that a simple check for a Linux console and UTF-8
> > terminal encoding, plus a character being inside a BMP, don't?
> 
> terminal_glyph_code gets the current set of at-most-512 displayable 
> characters from from the kernel.

Right, I missed the 512-character part.  Quite a limitation, btw.

So, the plan seems to be this:

  . make sure the terminal is in Unicode mode, and that the user
    didn't override by a call to set-terminal-coding-system
  . if a character has a glyph in the Unicode font, send a UTF-8
    encoding for the character to the screen, disregarding the
    terminal encoding as mandated by the locale
  . if the character doesn't have a glyph in the console font, treat
    it as glyphless
  . if the conditions in the first item above are not met, fall back
    to the current code which encodes using the terminal encoding

I notice that we don't use terminal_glyph_code when determining
whether a given character should be treated as glyphless, so I guess
that means we could produce something other than what
glyphless-char-display says for a given character; this should be
fixed.

Also, the above means set-locale-environment should not call
set-terminal-coding-system if the display is a Linux console that
supports this feature.

Is that right?





  reply	other threads:[~2017-04-15  8:48 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-08  2:20 bug#26396: 25.1; char-displayable-p on a latin1 tty Kevin Ryde
2017-04-08  7:42 ` Eli Zaretskii
2017-04-09  5:16   ` Kevin Ryde
2017-04-10  6:47     ` Eli Zaretskii
2017-04-10  7:05       ` Eli Zaretskii
2017-04-10  7:45         ` Eli Zaretskii
2017-04-13  6:19         ` Paul Eggert
2017-04-13  7:16           ` Eli Zaretskii
2017-04-13 20:58             ` Paul Eggert
2017-04-14  3:01               ` Kevin Ryde
2017-04-14 18:59                 ` Paul Eggert
2017-04-14 12:37               ` Eli Zaretskii
2017-04-14 18:56                 ` Paul Eggert
2017-04-15  8:48                   ` Eli Zaretskii [this message]
2017-04-15 21:12                     ` Paul Eggert
2017-04-16  5:59                       ` Eli Zaretskii
2017-04-16 20:25                         ` Paul Eggert
2017-04-17  6:19                           ` Eli Zaretskii
2017-04-17  3:00                         ` Kevin Ryde
2017-04-17  3:26                           ` Paul Eggert
2017-04-17  5:56                             ` Paul Eggert
2017-04-17  7:33                               ` Eli Zaretskii
2017-04-17 17:22                                 ` Paul Eggert
2017-04-17  6:24                             ` Eli Zaretskii
2017-04-17  6:41                               ` Paul Eggert
2017-04-17  7:27                                 ` Kevin Ryde
2017-04-17  8:08                                 ` Eli Zaretskii
2017-04-17 18:08                                   ` Paul Eggert
2017-04-17 18:32                                     ` Eli Zaretskii
2017-04-18 17:49                                       ` Paul Eggert
2017-04-18 18:19                                         ` Eli Zaretskii
2017-04-13 22:07           ` Richard Stallman
2017-04-13 22:18             ` Paul Eggert
2017-04-14 19:48               ` Richard Stallman
2017-04-11  7:22       ` Kevin Ryde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lxqgipc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=26396@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=user42_kevin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).