unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Robert Cochran <robert+Emacs@cochranmail.com>
Cc: 27122@debbugs.gnu.org, v.schneidermann@gmail.com
Subject: bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex
Date: Mon, 29 May 2017 22:52:37 +0300	[thread overview]
Message-ID: <834lw3fnju.fsf@gnu.org> (raw)
In-Reply-To: <87y3tfqz6c.fsf@SoraLaptop> (message from Robert Cochran on Mon,  29 May 2017 11:46:03 -0700)

> From: Robert Cochran <robert+Emacs@cochranmail.com>
> Cc: Eli Zaretskii <eliz@gnu.org>,  27122@debbugs.gnu.org
> Date: Mon, 29 May 2017 11:46:03 -0700
> 
> what is wrong with adding what is clearly an option, so it can be
> changed in one place and be done with it?

Complexity and maintainability.  The code which handles special
characters is already almost 140 lines of terse C, controlled by 2
obscure variables (ever heard of printable-chars, for example?) and 2
special faces.  And that's excluding the glyphless-char-display stuff,
which adds even more.  It's almost impossible to tell in advance how
will some specific codepoint be displayed if the terminal cannot
handle it "normally".  At least I need to read the involved code every
time I have to answer such questions.

I'd rather not add to this any more complexity, unless it's really
needed.  That is why I'd like to understand the details of the use
case: to see whether we already have a reasonable solution for it.





  reply	other threads:[~2017-05-29 19:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-28 20:42 bug#27122: 26.0.50; [PATCH] Add customizable to display unprintables as hex Vasilij Schneidermann
2017-05-29  2:33 ` Eli Zaretskii
2017-05-29  6:28   ` Vasilij Schneidermann
2017-05-29 18:46     ` Robert Cochran
2017-05-29 19:52       ` Eli Zaretskii [this message]
2017-05-29 20:20         ` Vasilij Schneidermann
2017-05-29 23:55           ` Robert Cochran
2017-05-30  0:11             ` npostavs
2017-05-30  0:47               ` Robert Cochran
2017-05-29 19:39     ` Eli Zaretskii
2017-05-29 20:15       ` Vasilij Schneidermann
2017-05-30  6:24         ` Eli Zaretskii
2017-05-30  8:16           ` Vasilij Schneidermann
2017-05-30  8:38             ` Eli Zaretskii
2017-06-01 17:05               ` Vasilij Schneidermann
2017-06-01 18:19                 ` Eli Zaretskii
2017-05-30 12:06           ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lw3fnju.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27122@debbugs.gnu.org \
    --cc=robert+Emacs@cochranmail.com \
    --cc=v.schneidermann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).