From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25082: [PATCH] Add support to emacsclient for command-lline options in ALTERNATE_EDITOR/--alternate-editor Date: Wed, 30 Aug 2017 19:48:12 +0300 Message-ID: <834lsp2e9f.fsf@gnu.org> References: <83val93vrk.fsf@gnu.org> <83val62xcb.fsf@gnu.org> <83shga2ubi.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1504111753 29460 195.159.176.226 (30 Aug 2017 16:49:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 30 Aug 2017 16:49:13 +0000 (UTC) Cc: 25082@debbugs.gnu.org To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 30 18:49:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn6At-0007LF-6y for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Aug 2017 18:49:07 +0200 Original-Received: from localhost ([::1]:51596 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn6B0-0007pz-AA for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Aug 2017 12:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55134) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn6At-0007pj-Ah for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2017 12:49:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn6Ao-00036A-PM for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2017 12:49:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54378) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dn6Ao-000366-MA for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2017 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dn6Ao-0006v7-EZ for bug-gnu-emacs@gnu.org; Wed, 30 Aug 2017 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Aug 2017 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25082-submit@debbugs.gnu.org id=B25082.150411171826566 (code B ref 25082); Wed, 30 Aug 2017 16:49:02 +0000 Original-Received: (at 25082) by debbugs.gnu.org; 30 Aug 2017 16:48:38 +0000 Original-Received: from localhost ([127.0.0.1]:34824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn6AQ-0006uP-Am for submit@debbugs.gnu.org; Wed, 30 Aug 2017 12:48:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:35813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dn6AO-0006uB-JH for 25082@debbugs.gnu.org; Wed, 30 Aug 2017 12:48:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dn6AI-0002wV-Nx for 25082@debbugs.gnu.org; Wed, 30 Aug 2017 12:48:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41328) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dn6AI-0002wQ-LF; Wed, 30 Aug 2017 12:48:30 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2222 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dn6AH-00079o-Ow; Wed, 30 Aug 2017 12:48:30 -0400 In-reply-to: (message from Reuben Thomas on Tue, 29 Aug 2017 23:29:24 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136386 Archived-At: > From: Reuben Thomas > Date: Tue, 29 Aug 2017 23:29:24 +0100 > Cc: Glenn Morris , 25082@debbugs.gnu.org > > I attach an updated patch with the documentation changes (to manual and NEWS).​ LGTM, thanks. > The issue I alluded to is a subtle misfeature in the Windows > implementation of execvp (and similar Posix functions): the arguments > you pass via the argv array get concatenated into a single > command-line string, and that string is passed to the Windows system > API that actually invokes the program. So argv[] elements that > include whitespace need to be quoted(!) to work correctly on > MS-Windows. (Of course, this quoting must be ifdef'ed away for Posix > platforms.) > > ​I see, thanks for the explanation. Doesn't w32_execvp handle this already? Indeed, it does. Thanks for reminding we already had that covered.