From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28342: 26.0.50; (OSX) Jumpy Scrolling using Trackpad Date: Sat, 09 Sep 2017 17:25:45 +0300 Message-ID: <834lscvthy.fsf@gnu.org> References: <225582B1-4598-4966-AE0B-4E8C153C8BF2@fastmail.com> <83h8wf22cy.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1504967186 25769 195.159.176.226 (9 Sep 2017 14:26:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 9 Sep 2017 14:26:26 +0000 (UTC) Cc: 28342@debbugs.gnu.org To: Nick Helm Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Sep 09 16:26:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqghy-0005jq-KV for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Sep 2017 16:26:06 +0200 Original-Received: from localhost ([::1]:49710 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqgi5-0007SB-Uj for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Sep 2017 10:26:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqghx-0007Qw-LX for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 10:26:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqghu-000522-FK for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 10:26:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48933) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dqghu-00051y-CY for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 10:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dqghu-0006ro-7i for bug-gnu-emacs@gnu.org; Sat, 09 Sep 2017 10:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Sep 2017 14:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28342-submit@debbugs.gnu.org id=B28342.150496714826374 (code B ref 28342); Sat, 09 Sep 2017 14:26:02 +0000 Original-Received: (at 28342) by debbugs.gnu.org; 9 Sep 2017 14:25:48 +0000 Original-Received: from localhost ([127.0.0.1]:57613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqghf-0006rK-RS for submit@debbugs.gnu.org; Sat, 09 Sep 2017 10:25:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqghd-0006r6-US for 28342@debbugs.gnu.org; Sat, 09 Sep 2017 10:25:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqghV-0004wT-FW for 28342@debbugs.gnu.org; Sat, 09 Sep 2017 10:25:40 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqghV-0004wP-9Q; Sat, 09 Sep 2017 10:25:37 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1525 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqghU-0003S1-Re; Sat, 09 Sep 2017 10:25:37 -0400 In-reply-to: (message from Nick Helm on Thu, 07 Sep 2017 13:58:45 +1200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:136706 Archived-At: > From: Nick Helm > Cc: Eli Zaretskii > Date: Thu, 07 Sep 2017 13:58:45 +1200 > > The problem might lie in window_scroll_pixel_based in window.c. A small > tweak seems to help: > > --- src/window.c 2017-09-07 13:16:29.000000000 +1200 > +++ src/window.c 2017-09-07 13:10:04.000000000 +1200 > @@ -4835,7 +4835,7 @@ > have the `scroll-command' property. This avoids the > possibility of point becoming "stuck" on a tall line when > scrolling by one line. */ > - if (window_scroll_pixel_based_preserve_y < 0 > + if (window_scroll_pixel_based_preserve_y <= 0 > || !SYMBOLP (KVAR (current_kboard, Vlast_command)) > || NILP (Fget (KVAR (current_kboard, Vlast_command), Qscroll_command))) > { Thanks, but this change only fixes the problem when you start scrolling with point on the first line in the window. If point is on 2nd, 3rd, or 4th line (more generally, any line inside the scroll-margin), the bug will still be there. I installed on master a more general fix, which I hope solves this problem.