unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gemini Lasswell <gazally@runbox.com>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 27653@debbugs.gnu.org, mu@miroslavurbanek.com
Subject: bug#27653: Patch for bug#27653: 25.2; ses.el text cell justification
Date: Thu, 05 Oct 2017 13:09:31 +0300	[thread overview]
Message-ID: <834lrdykh0.fsf@gnu.org> (raw)
In-Reply-To: <87tvzkf47p.fsf_-_@runbox.com> (message from Gemini Lasswell on Sat, 30 Sep 2017 11:11:40 -0700)

> From: Gemini Lasswell <gazally@runbox.com>
> Cc: Miroslav Urbanek <mu@miroslavurbanek.com>,  27653@debbugs.gnu.org
> Date: Sat, 30 Sep 2017 11:11:40 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Could you please provide a minimal recipe, starting from "emacs -Q",
> > that could be used to reproduce the problem?
> 
> >From emacs -Q:
> 
> C-x C-f abc.ses RET
> " abc RET
> 
> Result: The text is left justified.
> 
> I looked through those and found a change in df5703a00d which looked
> like a likely suspect. Reverting it fixes the bug. It looks to me like
> the only thing the change affects is justification of text cells, but
> someone who is familiar with ses.el should have a look at it.

Stefan, the change in ses-print-cell that causes this bug is not
mentioned in the log message of df5703a00d.  Can you tell why you made
that change?

> >From da3b761e2e5fb10f1512befb7399a198e2419faa Mon Sep 17 00:00:00 2001
> From: Gemini Lasswell <gazally@runbox.com>
> Date: Sat, 30 Sep 2017 10:31:25 -0700
> Subject: [PATCH] * lisp/ses.el (ses-print-cell): Fix alignment of text cells
>  (bug#27653)
> 
> ---
>  lisp/ses.el | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lisp/ses.el b/lisp/ses.el
> index 9221476e7a..4c19c70c5d 100644
> --- a/lisp/ses.el
> +++ b/lisp/ses.el
> @@ -1254,8 +1254,7 @@ ses-print-cell
>  	 ((< len width)
>  	  ;; Fill field to length with spaces.
>  	  (setq len  (make-string (- width len) ?\s)
> -		text (if (or (stringp value)
> -			     (eq ses-call-printer-return t))
> +		text (if (eq ses-call-printer-return t)
>  			 (concat text len)
>  		       (concat len text))))
>  	 ((> len width)
> -- 
> 2.14.1
> 





  reply	other threads:[~2017-10-05 10:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 14:02 bug#27653: 25.2; ses.el text cell justification Miroslav Urbanek
2017-09-02 14:08 ` Eli Zaretskii
2017-09-30 18:11   ` bug#27653: Patch for " Gemini Lasswell
2017-10-05 10:09     ` Eli Zaretskii [this message]
2017-10-05 13:18       ` Stefan Monnier
2017-10-05 13:54         ` Eli Zaretskii
2017-10-11 10:28           ` Miroslav Urbanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lrdykh0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=27653@debbugs.gnu.org \
    --cc=gazally@runbox.com \
    --cc=monnier@iro.umontreal.ca \
    --cc=mu@miroslavurbanek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).