From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii <eliz@gnu.org> Newsgroups: gmane.emacs.bugs Subject: bug#28631: 25.3.50; Deactivate mark with Ctrl-g mess up the primary-selection Date: Sat, 14 Oct 2017 09:56:20 +0300 Message-ID: <834lr2jjzf.fsf@gnu.org> References: <87ing3w8rk.fsf@gmail.com> <87o9pdazmp.fsf@users.sourceforge.net> <87o9pdaxfo.fsf@gmail.com> <87infjc1s1.fsf@users.sourceforge.net> <83a80vlf0w.fsf@gnu.org> <878tgf8o9u.fsf@gmail.com> <87y3of9nrn.fsf@users.sourceforge.net> <alpine.DEB.2.20.1710141030010.31750@calancha-pc> <87shema39u.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii <eliz@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1507964238 10287 195.159.176.226 (14 Oct 2017 06:57:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 06:57:18 +0000 (UTC) Cc: 28631@debbugs.gnu.org, tino.calancha@gmail.com To: Noam Postavsky <npostavs@users.sourceforge.net> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 14 08:57:14 2017 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>) id 1e3GNe-00012u-8p for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 08:57:06 +0200 Original-Received: from localhost ([::1]:53012 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org>) id 1e3GNk-000647-1y for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 02:57:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e3GNe-00063m-2E for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 02:57:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e3GNa-0003Sd-6C for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 02:57:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e3GNa-0003SX-2E for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 02:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e3GNZ-0000RU-N8 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 02:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii <eliz@gnu.org> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 06:57:01 +0000 Resent-Message-ID: <handler.28631.B28631.15079641981665@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28631 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28631-submit@debbugs.gnu.org id=B28631.15079641981665 (code B ref 28631); Sat, 14 Oct 2017 06:57:01 +0000 Original-Received: (at 28631) by debbugs.gnu.org; 14 Oct 2017 06:56:38 +0000 Original-Received: from localhost ([127.0.0.1]:38708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1e3GNC-0000Qn-IX for submit@debbugs.gnu.org; Sat, 14 Oct 2017 02:56:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@gnu.org>) id 1e3GNA-0000QW-Sr for 28631@debbugs.gnu.org; Sat, 14 Oct 2017 02:56:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from <eliz@gnu.org>) id 1e3GN1-0003E8-S8 for 28631@debbugs.gnu.org; Sat, 14 Oct 2017 02:56:31 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <eliz@gnu.org>) id 1e3GN1-0003Du-Oc; Sat, 14 Oct 2017 02:56:27 -0400 Original-Received: from [176.228.60.248] (port=3156 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@gnu.org>) id 1e3GN0-0006nO-Ej; Sat, 14 Oct 2017 02:56:27 -0400 In-reply-to: <87shema39u.fsf@users.sourceforge.net> (message from Noam Postavsky on Fri, 13 Oct 2017 22:09:49 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <http://lists.gnu.org/archive/html/bug-gnu-emacs/> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org> Xref: news.gmane.org gmane.emacs.bugs:138378 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/138378> > From: Noam Postavsky <npostavs@users.sourceforge.net> > Cc: Eli Zaretskii <eliz@gnu.org>, 28631@debbugs.gnu.org > Date: Fri, 13 Oct 2017 22:09:49 -0400 > > >> That patch only has affect during winner-undo, no? > > I think so. > > Actually, I thought about it a bit more, and realized it could also > affect things like post-command hooks that are run after winner-undo. > > >> Maybe only the (setf (winner-active-region) (cdr entry)) part should be > >> skipped? > > We need to ban > > (set-mark (car entry)) > > as well, because it updates the primary selection. > > Ah, okay. > > > I assume if someone have set select-enable-primary, then she > > probably doesn't want winner-undo to change her selection. > > Seems reasonable. Please push to emacs-26 in a few days, if no comments or objections surface. Thanks.