unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Van L <van@scratch.space>
Cc: 31706@debbugs.gnu.org
Subject: bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull
Date: Mon, 04 Jun 2018 18:51:18 +0300	[thread overview]
Message-ID: <834liiczyh.fsf@gnu.org> (raw)
In-Reply-To: <C56B9AE3-19CA-4DB4-80B3-2C83A65BDBAC@scratch.space> (message from Van L on Mon, 4 Jun 2018 18:26:11 +1000)

> From: Van L <van@scratch.space>
> Date: Mon, 4 Jun 2018 18:26:11 +1000
> 
> After a vc-pull on a git directory, a vc-git buffer shows with links to files that have changed.
> 
> — example
> Running "git pull"...
> From git://github.com/apple/foundationdb
>    ab5bfad..ce6a2f0  master     -> origin/master
> Updating ab5bfad..ce6a2f0
> Fast-forward
>  fdbclient/CoordinationInterface.h     |  2 +-
>  fdbclient/DatabaseContext.h           |  3 +-
>  fdbclient/Knobs.cpp                   |  1 +
>  fdbclient/Knobs.h                     |  1 +
>  fdbclient/MasterProxyInterface.h      |  2 +-
>  fdbclient/MonitorLeader.actor.cpp     | 84 +++++++++++++++++++----------------
>  fdbclient/NativeAPI.actor.cpp         | 17 ++++---
>  fdbclient/NativeAPI.h                 |  2 +-
>  fdbclient/ReadYourWrites.h            |  1 -
>  fdbrpc/batcher.actor.h                | 20 ++++++---
>  fdbserver/Knobs.cpp                   |  4 ++
>  fdbserver/Knobs.h                     |  4 ++
>  fdbserver/LeaderElection.actor.cpp    | 30 ++++++-------
>  fdbserver/MasterProxyServer.actor.cpp | 32 +++++++++----
>  fdbserver/fdbserver.actor.cpp         |  7 ++-
>  flow/error_definitions.h              |  1 +
>  flow/network.h                        |  1 +
>  17 files changed, 131 insertions(+), 81 deletions(-)
> 
> — end example
> 
> Clicking on a link causes the ,system default open, to call the operating system’s file manager to open that file.
> 
> Expected desired behavior is that Emacs 26.1 simply visits the ,flow/network.h, file (on event ,mouse-1: visit this file,)

I cannot reproduce this.  I get exactly the behavior you expect.
Could be some problem specific to your platform (which is what, btw?).

> Trying to find the elisp function the mouse click calls, I do:
> 
>  1. C-h k
>  2. <mouse click on ,flow/network.h,>
>  3. the echo area shows: mouse-1-
> 
> if I click the mouse a second time I get the explanation for: (mouse-drag-region START-EVENT)

Try "M-x describe-text-properties RET" with point on one of the links.
(I guess "C-h k" needs to be extended to be smarter in this case.)





  parent reply	other threads:[~2018-06-04 15:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04  8:26 bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Van L
     [not found] ` <handler.31706.B.152810079227439.ack@debbugs.gnu.org>
2018-06-04  8:49   ` bug#31706: Acknowledgement (Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull) Van L
2018-06-04 15:51 ` Eli Zaretskii [this message]
2018-06-05  3:43   ` bug#31706: Emacs 26.1 unable to visit files in vc-git buffer's links after vc-pull Van L
2018-06-05 14:25     ` Eli Zaretskii
2018-06-05 15:07       ` Van L
2018-06-07 20:52       ` Alan Third
2018-06-08  6:39         ` Eli Zaretskii
2018-06-10 15:35           ` Alan Third
2018-06-10 16:09             ` Eli Zaretskii
2018-06-10 20:14               ` Alan Third
2018-06-11  2:27                 ` Eli Zaretskii
2018-06-12 20:23                   ` Alan Third
2018-06-13  2:30                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834liiczyh.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=31706@debbugs.gnu.org \
    --cc=van@scratch.space \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).