From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32051: 26.1; grep-regexp-alist on windows Date: Fri, 06 Jul 2018 11:51:56 +0300 Message-ID: <834lhcn3v7.fsf@gnu.org> References: <65653506844b4308957893b429dea091@chihq-post2.XRTRADING.LOCAL> <83in5vnf0s.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1530867067 11351 195.159.176.226 (6 Jul 2018 08:51:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2018 08:51:07 +0000 (UTC) Cc: 32051@debbugs.gnu.org, Dan.Harms@xrtrading.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 06 10:51:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMSD-0002iP-0r for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2018 10:51:01 +0200 Original-Received: from localhost ([::1]:56428 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbMUK-0003Os-9O for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2018 04:53:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbMUD-0003Oj-K9 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 04:53:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbMUA-00050x-D0 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 04:53:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40306) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fbMUA-00050L-8M for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 04:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fbMU9-0007U7-Vu for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2018 04:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jul 2018 08:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32051 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32051-submit@debbugs.gnu.org id=B32051.153086712528699 (code B ref 32051); Fri, 06 Jul 2018 08:53:01 +0000 Original-Received: (at 32051) by debbugs.gnu.org; 6 Jul 2018 08:52:05 +0000 Original-Received: from localhost ([127.0.0.1]:48203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMTF-0007Sp-7P for submit@debbugs.gnu.org; Fri, 06 Jul 2018 04:52:05 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fbMTD-0007SK-NH for 32051@debbugs.gnu.org; Fri, 06 Jul 2018 04:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fbMT5-0000BL-C1 for 32051@debbugs.gnu.org; Fri, 06 Jul 2018 04:51:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fbMT5-0000Ay-7t; Fri, 06 Jul 2018 04:51:55 -0400 Original-Received: from [176.228.60.248] (port=2086 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fbMT4-0006Mv-L7; Fri, 06 Jul 2018 04:51:55 -0400 In-reply-to: (message from Noam Postavsky on Wed, 4 Jul 2018 15:57:53 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148241 Archived-At: > From: Noam Postavsky > Date: Wed, 4 Jul 2018 15:57:53 -0400 > Cc: Dan Harms , 32051@debbugs.gnu.org > > Looking at the grep-regexp-alist, it is the case that a filename with > a colon will not be matched when grep doesn't support --null. In the > case where grep does support --null, the NUL byte is displayed like a > colon, so the difference might not leap out at you. Right, thanks. > I think the patch below would fix it: Looks reasonable. Can we have a test for this use case, so that we never again regress like that?