From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#32276: char-width of a space is 0 when display-table entry has a face. Date: Sun, 29 Jul 2018 17:45:14 +0300 Message-ID: <834lgit81x.fsf@gnu.org> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1532875451 19672 195.159.176.226 (29 Jul 2018 14:44:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 29 Jul 2018 14:44:11 +0000 (UTC) Cc: 32276@debbugs.gnu.org, esq@lawlist.com To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 29 16:44:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmvW-00051a-Nl for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 16:44:06 +0200 Original-Received: from localhost ([::1]:48667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjmxd-000251-29 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Jul 2018 10:46:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40596) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjmxS-00024Z-3k for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 10:46:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjmxO-0001Dr-VM for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 10:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:57202) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjmxO-0001Dj-RO for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 10:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjmxO-0006zA-K4 for bug-gnu-emacs@gnu.org; Sun, 29 Jul 2018 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jul 2018 14:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32276 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32276-submit@debbugs.gnu.org id=B32276.153287553726787 (code B ref 32276); Sun, 29 Jul 2018 14:46:02 +0000 Original-Received: (at 32276) by debbugs.gnu.org; 29 Jul 2018 14:45:37 +0000 Original-Received: from localhost ([127.0.0.1]:33983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmwz-0006xz-FE for submit@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:37 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fjmwx-0006xj-MR for 32276@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjmwp-000103-8B for 32276@debbugs.gnu.org; Sun, 29 Jul 2018 10:45:30 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjmwY-0000sg-EN; Sun, 29 Jul 2018 10:45:10 -0400 Original-Received: from [176.228.60.248] (port=1834 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fjmwX-0003xc-Ka; Sun, 29 Jul 2018 10:45:10 -0400 In-reply-to: (message from Paul Eggert on Sat, 28 Jul 2018 15:37:50 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149049 Archived-At: > Cc: 32276@debbugs.gnu.org, Keith David Bershatsky > From: Paul Eggert > Date: Sat, 28 Jul 2018 15:37:50 -0700 > > Unfortunately that change causes the emacs-26 build to fail for me: Sorry about that. > make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src' > CC character.o > In file included from character.c:34:0: > character.c: In function ‘char_width’: > lisp.h:1682:11: error: ‘c’ may be used uninitialized in this function > [-Werror=maybe-uninitialized] > ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \ > ^ > character.c:292:10: note: ‘c’ was declared here > int c; > ^ > cc1: all warnings being treated as errors > Makefile:376: recipe for target 'character.o' failed > > Although the attached patch fixes this and presumably speeds up the code a bit > when optimized, is this the right thing to do? I have not looked into the code > carefully. I preferred to keep the modified code work the same as before that change, i.e. count any non-characters (which now shouldn't happen, I think) as having a width of zero. So I pushed a slightly different fix.