From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 32276@debbugs.gnu.org, esq@lawlist.com
Subject: bug#32276: char-width of a space is 0 when display-table entry has a face.
Date: Sun, 29 Jul 2018 17:45:14 +0300 [thread overview]
Message-ID: <834lgit81x.fsf@gnu.org> (raw)
In-Reply-To: <b07c86f5-ebad-cc56-5e5a-04d71b27f087@cs.ucla.edu> (message from Paul Eggert on Sat, 28 Jul 2018 15:37:50 -0700)
> Cc: 32276@debbugs.gnu.org, Keith David Bershatsky <esq@lawlist.com>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 28 Jul 2018 15:37:50 -0700
>
> Unfortunately that change causes the emacs-26 build to fail for me:
Sorry about that.
> make[1]: Entering directory '/home/eggert/src/gnu/emacs/emacs-26-sc/src'
> CC character.o
> In file included from character.c:34:0:
> character.c: In function ‘char_width’:
> lisp.h:1682:11: error: ‘c’ may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> ? ((a) + (unsigned) 0) op ((b) + (unsigned) 0) \
> ^
> character.c:292:10: note: ‘c’ was declared here
> int c;
> ^
> cc1: all warnings being treated as errors
> Makefile:376: recipe for target 'character.o' failed
>
> Although the attached patch fixes this and presumably speeds up the code a bit
> when optimized, is this the right thing to do? I have not looked into the code
> carefully.
I preferred to keep the modified code work the same as before that
change, i.e. count any non-characters (which now shouldn't happen, I
think) as having a width of zero. So I pushed a slightly different
fix.
prev parent reply other threads:[~2018-07-29 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 3:33 bug#32276: char-width of a space is 0 when display-table entry has a face Keith David Bershatsky
2018-07-27 9:34 ` Eli Zaretskii
2018-07-28 22:37 ` Paul Eggert
2018-07-29 14:45 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834lgit81x.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=32276@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=esq@lawlist.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).