From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29923: [PATCH] Skip writing empty abbrev tables Date: Wed, 19 Sep 2018 09:44:11 +0300 Message-ID: <834lemf0lg.fsf@gnu.org> References: <87tvmyflla.fsf@gmail.com> <874lemquwr.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1537339387 11711 195.159.176.226 (19 Sep 2018 06:43:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 19 Sep 2018 06:43:07 +0000 (UTC) Cc: vianchielfaura@gmail.com, npostavs@gmail.com, 29923@debbugs.gnu.org To: Allen Li Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 19 08:43:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2WCU-0002vF-H9 for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 08:43:02 +0200 Original-Received: from localhost ([::1]:43904 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2WEb-0004In-1g for geb-bug-gnu-emacs@m.gmane.org; Wed, 19 Sep 2018 02:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2WEU-0004IO-21 for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2WEQ-0005e7-0M for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40790) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g2WEP-0005dl-RM for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g2WEP-0004rD-PA for bug-gnu-emacs@gnu.org; Wed, 19 Sep 2018 02:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Sep 2018 06:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29923 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29923-submit@debbugs.gnu.org id=B29923.153733946318601 (code B ref 29923); Wed, 19 Sep 2018 06:45:01 +0000 Original-Received: (at 29923) by debbugs.gnu.org; 19 Sep 2018 06:44:23 +0000 Original-Received: from localhost ([127.0.0.1]:45048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2WDn-0004px-Kl for submit@debbugs.gnu.org; Wed, 19 Sep 2018 02:44:23 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g2WDl-0004pj-Kr for 29923@debbugs.gnu.org; Wed, 19 Sep 2018 02:44:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g2WDc-0004rt-Gs for 29923@debbugs.gnu.org; Wed, 19 Sep 2018 02:44:16 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35586) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g2WDc-0004rV-CC; Wed, 19 Sep 2018 02:44:12 -0400 Original-Received: from [176.228.60.248] (port=4957 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1g2WDb-00081T-PM; Wed, 19 Sep 2018 02:44:12 -0400 In-reply-to: (message from Allen Li on Tue, 18 Sep 2018 19:55:38 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150438 Archived-At: > From: Allen Li > Date: Tue, 18 Sep 2018 19:55:38 -0700 > Cc: Allen Li , 29923@debbugs.gnu.org > > > Ah, it would be good to have this information in the commit message, as > > the patch is a bit confusing to read otherwise. > > Done. I have also removed the system abbrev check in abbrev--write since > it is redundant now and this is the only place it is called. I think this change in behavior warrants a NEWS entry, and I think the description in the ELisp manual should also be updated. > To implement this, we need to filter out out system abbrevs before ^^^^^^^ A typo. Thanks.