unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Hudson <phil.hudson@iname.com>
Cc: 33460-done@debbugs.gnu.org
Subject: bug#33460: 24.4; Eshell histfile symlinks not followed
Date: Sat, 08 Dec 2018 11:15:27 +0200	[thread overview]
Message-ID: <834lbo5qhc.fsf@gnu.org> (raw)
In-Reply-To: <CAJ1MqVFNDtayq6O_B_dEibp5fieBgYQedsB=ykHSqkZYKsTJng@mail.gmail.com> (message from Philip Hudson on Wed, 21 Nov 2018 23:09:16 +0000)

> From: Philip Hudson <phil.hudson@iname.com>
> Date: Wed, 21 Nov 2018 23:09:16 +0000
> 
> If the file named by the value of option `eshell-history-file-name' is
> a symbolic link, then it will be replaced and overwritten instead. It
> should be dereferenced (followed) first, and its target file should be
> replaced and overwritten.
> 
> The attached patch uses function `file-truename' to fix this. The
> patch was made using source cloned from git savannah HEAD today, which
> I think is version 26.1.90, based on ChangeLog.3 in the cloned repo.

Thanks, pushed to the master branch, to appear in Emacs 27.1.

Please in the future provide a ChangeLog-style commit log entry for
your changes; see CONTRIBUTE for the details.

Also, user-visible behavior changes need to be called out in NEWS, and
if necessary also in the relevant Texinfo manual(s).





      parent reply	other threads:[~2018-12-08  9:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-21 23:09 bug#33460: 24.4; Eshell histfile symlinks not followed Philip Hudson
2018-11-24  0:16 ` bug#33477: 24.4; Eshell history/lastdir file " Philip Hudson
2018-12-08  9:20   ` Eli Zaretskii
2018-12-08  9:15 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834lbo5qhc.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33460-done@debbugs.gnu.org \
    --cc=phil.hudson@iname.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).