unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 35413@debbugs.gnu.org
Subject: bug#35413: [PATCH] Use lexical binding for ediff
Date: Fri, 03 May 2019 11:53:05 +0300	[thread overview]
Message-ID: <834l6bor66.fsf@gnu.org> (raw)
In-Reply-To: <875zr3pnpj.fsf@gmail.com> (message from Alex Branham on Wed, 24 Apr 2019 07:55:20 -0500)

> From: Alex Branham <alex.branham@gmail.com>
> Date: Wed, 24 Apr 2019 07:55:20 -0500

Sorry for a long delay in responding.

> I've attached a patch that converts ediff to use lexical-binding. I've
> been using it locally for a couple of weeks without noticing any issues,
> though I'm not a super-heavy ediff user.

I assume you ran all ediff tests we have, but did you also try
commands outside the ediff-* group, to make sure they still work?  I
think VC has some commands, and there's also emerge.

I have a couple of questions regarding the changes:

> (ediff-prepare-meta-buffer): Remove unused startup-hooks
> (ediff-multi-patch-internal): Remove unused variable startup-hooks.

startup-hooks are used by emerge and maybe by users.  Why remove it?

> (ediff-date): Remove.

Why?

> @@ -714,9 +714,8 @@ behavior."
>  ;; we may visit them recursively.  DIR1 is the directory to inspect.
>  ;; MERGE-AUTOSTORE-DIR is the directory where to auto-store the results of
>  ;; merges.  Can be nil.
> -(defun ediff-get-directory-files-under-revision (jobname
> -						 regexp dir1
> -						 &optional merge-autostore-dir)
> +(defun ediff-get-directory-files-under-revision (regexp dir1
> +						        &optional merge-autostore-dir)

This and other hunks change signatures of public functions, which is
always a problem.  Is this a must?  Can't we leave the signatures
alone?  If not, what are the problems that necessitate that?

Thanks.





  reply	other threads:[~2019-05-03  8:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 12:55 bug#35413: [PATCH] Use lexical binding for ediff Alex Branham
2019-05-03  8:53 ` Eli Zaretskii [this message]
2019-05-14 12:31   ` Alex Branham
2019-06-07 14:24     ` Eli Zaretskii
2019-06-09 15:02       ` Alex Branham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834l6bor66.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=35413@debbugs.gnu.org \
    --cc=alex.branham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).