From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36219: GNU Emacs 26.1 --eval rejects trailing whitespace Date: Sat, 15 Jun 2019 16:54:52 +0300 Message-ID: <834l4rvtqr.fsf@gnu.org> References: <87ftobynvt.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="170194"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andpuke@foxmail.com, 36219@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 15 15:55:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hc99B-000i5j-Ft for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 15:55:09 +0200 Original-Received: from localhost ([::1]:60706 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc99A-00031N-HK for geb-bug-gnu-emacs@m.gmane.org; Sat, 15 Jun 2019 09:55:08 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51493) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hc995-00031G-Rr for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 09:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hc994-0006hQ-RA for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 09:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53196) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hc994-0006hI-Mi for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 09:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hc994-0000aV-Ka for bug-gnu-emacs@gnu.org; Sat, 15 Jun 2019 09:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jun 2019 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36219-submit@debbugs.gnu.org id=B36219.15606068952237 (code B ref 36219); Sat, 15 Jun 2019 13:55:02 +0000 Original-Received: (at 36219) by debbugs.gnu.org; 15 Jun 2019 13:54:55 +0000 Original-Received: from localhost ([127.0.0.1]:38503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc98x-0000a0-1e for submit@debbugs.gnu.org; Sat, 15 Jun 2019 09:54:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hc98u-0000ZE-V3 for 36219@debbugs.gnu.org; Sat, 15 Jun 2019 09:54:53 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hc98o-0006V1-7i; Sat, 15 Jun 2019 09:54:46 -0400 Original-Received: from [176.228.60.248] (port=4416 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hc98n-0007mA-O3; Sat, 15 Jun 2019 09:54:46 -0400 In-reply-to: <87ftobynvt.fsf@gmail.com> (message from Noam Postavsky on Sat, 15 Jun 2019 09:33:10 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160613 Archived-At: > From: Noam Postavsky > Date: Sat, 15 Jun 2019 09:33:10 -0400 > Cc: 36219@debbugs.gnu.org > > writes: > > > Since commit a90d5e6309c0306d931d398506b242c3eb4f40d7 which fixes bug #23159 > > the `--eval' command line option signals (error "Trailing garbage following > > expression: %s") on more than one expression recevied. > > > This causes some old shell script snippets which has trailing newline for > > formatting no longer works, such as the follow script from > > https://orgmode.org/manual/Batch-Execution.html#Batch-Execution > > > > Since `eval-expression' accepts additional white space and newlines after a > > single expression, this mismatch behavior of `--eval' should be considered as a > > bug. > > > > My proposed fix is apply `string-trim-right` to received string of expression. > > > > I think I'd prefer checking the trailing garbage for whitespace, which > is what eval-expression does. See following patch: SGTM, thanks.