From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: shuguang79@qq.com, 36428@debbugs.gnu.org
Subject: bug#36428: Non-necessary progn afer with-eval-after-load in tramp in recent change
Date: Sat, 29 Jun 2019 12:55:19 +0300 [thread overview]
Message-ID: <834l48hg1k.fsf@gnu.org> (raw)
In-Reply-To: <87a7e0vld2.fsf@gmx.de> (message from Michael Albinus on Sat, 29 Jun 2019 10:36:41 +0200)
> From: Michael Albinus <michael.albinus@gmx.de>
> Date: Sat, 29 Jun 2019 10:36:41 +0200
> Cc: 36428@debbugs.gnu.org
>
> > In some recent changes to tramp, the 'eval-after-load' was replaced by
> > 'with-eval-after-load',
> > however, the unnecessary 'progn' function for the 'eval-after-load' is
> > no removed.
>
> Thanks, this was an overrsight by me. I'm willing to apply your patch,
> but it changes 47 lines; too much for a tiny patch.
>
> However, the real change touches just 10 lines, everything else are just
> indentation (white space) changes. So IMHO, the patch could be applied
> w/o signed papers.
>
> Eli?
Yes, this needs no legal paperwork.
Thanks.
next prev parent reply other threads:[~2019-06-29 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 3:49 bug#36428: Non-necessary progn afer with-eval-after-load in tramp in recent change Shuguang Sun
2019-06-29 8:36 ` Michael Albinus
2019-06-29 9:55 ` Eli Zaretskii [this message]
2019-06-29 10:23 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834l48hg1k.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36428@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=shuguang79@qq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).