From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#36740: 27.0.50; apparently buggy code in ccl.c (lookup-integer-constant) Date: Sat, 20 Jul 2019 16:51:38 +0300 Message-ID: <834l3gu845.fsf@gnu.org> References: <838sssu9rr.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="38271"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36740@debbugs.gnu.org To: pipcet@gmail.com, Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 20 15:52:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hopmU-0009oq-7o for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Jul 2019 15:52:10 +0200 Original-Received: from localhost ([::1]:51250 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hopmS-0003NY-2r for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Jul 2019 09:52:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50348) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hopmN-0003Lo-WD for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2019 09:52:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hopmN-0005iP-0n for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2019 09:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48128) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hopmM-0005iF-Tf for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2019 09:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hopmM-0003sC-RO for bug-gnu-emacs@gnu.org; Sat, 20 Jul 2019 09:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Jul 2019 13:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36740 X-GNU-PR-Package: emacs Original-Received: via spool by 36740-submit@debbugs.gnu.org id=B36740.156363071914872 (code B ref 36740); Sat, 20 Jul 2019 13:52:02 +0000 Original-Received: (at 36740) by debbugs.gnu.org; 20 Jul 2019 13:51:59 +0000 Original-Received: from localhost ([127.0.0.1]:56948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hopmJ-0003ro-41 for submit@debbugs.gnu.org; Sat, 20 Jul 2019 09:51:59 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hopmH-0003rP-7W for 36740@debbugs.gnu.org; Sat, 20 Jul 2019 09:51:57 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hopmA-0005YM-FE; Sat, 20 Jul 2019 09:51:51 -0400 Original-Received: from [176.228.60.248] (port=2653 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hopm9-0000CL-Hs; Sat, 20 Jul 2019 09:51:50 -0400 In-reply-to: <838sssu9rr.fsf@gnu.org> (message from Eli Zaretskii on Sat, 20 Jul 2019 16:15:52 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163466 Archived-At: > Date: Sat, 20 Jul 2019 16:15:52 +0300 > From: Eli Zaretskii > Cc: 36740@debbugs.gnu.org > > > From: Pip Cet > > Date: Sat, 20 Jul 2019 12:29:57 +0000 > > > > This code in ccl.c > > > > eop = hash_lookup (h, make_fixnum (reg[RRR]), NULL); > > if (eop >= 0) > > { > > Lisp_Object opl; > > opl = HASH_VALUE (h, eop); > > if (! (IN_INT_RANGE (eop) && CHARACTERP (opl))) > > CCL_INVALID_CMD; > > reg[RRR] = charset_unicode; > > reg[rrr] = eop; > > reg[7] = 1; /* r7 true for success */ > > } > > else > > reg[7] = 0; > > > > seems wrong to me. We look up the hash value for reg[RRR], but then we > > store the hash _index_ into reg[rrr], and throw away the actual value. > > The comment for the op-code says: > > #define CCL_LookupIntConstTbl 0x13 /* Lookup multibyte character by > integer key. Afterwards R7 set > to 1 if lookup succeeded. > 1:ExtendedCOMMNDRrrRRRXXXXXXXX > 2:ARGUMENT(Hash table ID) */ > > so there appears to be no significance to r7's value? Actually, I think you are right. In Emacs 22.1 we had this: case CCL_LookupIntConstTbl: op = XINT (ccl_prog[ic]); /* table */ ic++; { struct Lisp_Hash_Table *h = GET_HASH_TABLE (op); op = hash_lookup (h, make_number (reg[RRR]), NULL); if (op >= 0) { Lisp_Object opl; opl = HASH_VALUE (h, op); if (!CHAR_VALID_P (XINT (opl), 0)) CCL_INVALID_CMD; SPLIT_CHAR (XINT (opl), reg[RRR], i, j); if (j != -1) i = (i << 7) | j; reg[rrr] = i; reg[7] = 1; /* r7 true for success */ } else reg[7] = 0; } So this was fixed at some point, but for some reason the fix didn't make it into Emacs 23. So yes, I think we should use the value of XINT(opl) here.