From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Fri, 22 Nov 2019 09:20:02 +0200 Message-ID: <834kywxtr1.fsf@gnu.org> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="182368"; mail-complaints-to="usenet@blaine.gmane.org" Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 22 08:21:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iY3Fg-000lGv-CE for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 08:21:12 +0100 Original-Received: from localhost ([::1]:47748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY3Fe-0005bm-Nh for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Nov 2019 02:21:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35792) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iY3FX-0005bg-VG for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 02:21:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iY3FW-0002s1-Sh for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 02:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iY3FW-0002rw-Pk for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 02:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iY3FW-0005sY-DM for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2019 02:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Nov 2019 07:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157440720222491 (code B ref 38044); Fri, 22 Nov 2019 07:21:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 22 Nov 2019 07:20:02 +0000 Original-Received: from localhost ([127.0.0.1]:53650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3EV-0005qR-UL for submit@debbugs.gnu.org; Fri, 22 Nov 2019 02:20:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iY3ET-0005qE-Ah for 38044@debbugs.gnu.org; Fri, 22 Nov 2019 02:19:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49350) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iY3EM-0002NS-HC; Fri, 22 Nov 2019 02:19:51 -0500 Original-Received: from [176.228.60.248] (port=1908 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iY3EL-0006rh-OT; Fri, 22 Nov 2019 02:19:50 -0500 In-reply-to: <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> (message from Dmitry Gutov on Thu, 21 Nov 2019 23:05:07 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172192 Archived-At: > Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, > juri@linkov.net > From: Dmitry Gutov > Date: Thu, 21 Nov 2019 23:05:07 +0200 > > On 21.11.2019 22:19, Eli Zaretskii wrote: > > > Here's an alternative proposal. It seems like almost all VCS backends > > we support provide a variant of a "log" command that shows the diffs > > together with the usual meta-data shown by "log". Only RCS and CVS > > don't have such an option of "log", all the rest do (most of them via > > "log -p"). > > Somewhat better, but all backends would have to be updated anyway, for > this to work. It's new functionality, so that goes without saying. Or did you mean something specific when you said "updated"? > So the change in VC backend API is comparable to adding a new > action. We don't necessarily need a change in the API: vc-print-log-internal has enough arguments to pass this new meaning to it and to the backends. But even if there's a change in the API, it isn't a catastrophe from my POV. > I don't mind this too much (asking vc-git-print-log to include the diffs > makes sense, at least), but doing it this way loses out on the > opportunity to support all backends in one fell swoop. I don't understand why would we lose that opportunity. We will have to write new code for each backend in any alternative, and the code to add is really quite simple, so I'm probably missing something here, but what? > I hardly see myself ever choosing 'C-u C-u C-x v L' instead of 'M-x > vc-print-revision'. Simply because I'll never remember the former. That's fine. > Are you really that against a new command? Yes, more or less. IMO, we already have too many of them. VC used to be simple and elegant, and this proliferation of too many high-level commands makes it more and more complex, and inevitably causes us tweak the user level and UI to this or that particular VCS, which is wrong in the long run.