unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: 39360@debbugs.gnu.org
Subject: bug#39360: Add :extend attribute to show-paren-mode expression face
Date: Fri, 31 Jan 2020 17:32:42 +0200	[thread overview]
Message-ID: <834kwbljz9.fsf@gnu.org> (raw)
In-Reply-To: <a69304fb-c650-f0fe-aeba-749f26867d6a@gmail.com> (message from Clément Pit-Claudel on Fri, 31 Jan 2020 09:52:25 -0500)

> Cc: 39360@debbugs.gnu.org
> From: Clément Pit-Claudel <cpitclaudel@gmail.com>
> Date: Fri, 31 Jan 2020 09:52:25 -0500
> 
> > Please describe a use case where this problem shows up, I'm not sure I
> > understand it completely.  More accurately, I don't think I understand
> > why you think we must have the previous behavior with this face,
> > i.e. why the new behavior is "wrong".
> 
> Unless people were complaining about the old behavior for this particular face, I think that behavior was fine.

IMO it was not fine, because Emacs was behaving differently from every
other application out there which supports some form of highlighting
text that spans several lines.  The old behavior was also inconsistent
between different face attributes: background color behaved
differently from underline, for example, and GUI frames behaved
differently from TTY frames.

> More to the point, though, since the newline is inside the parentheses, it makes sense to me to extend the highlight continuously up to the edge of the window.

The newline is inside the parentheses, but the empty space to the
right of the newline is not part of the text.  Why should it be
highlighted?

> >> I might have missed discussions about this; is there a reason why :extend t isn't the default?
> > 
> > Because the whole idea of introducing :extend was that almost all
> > faces don't need this attribute.
> 
> I see.  The new default looks weird to me, but I'm sure I'll get used to it.

The question I'd like to ask is whether you'll get used to it wrt the
show-paren-mode face.

> Is there a reason to highlight one blank space at the end of each line, though, instead of only highlighting the text?

That blank space stands for the newline, so if the newline has that
face, the space glyph at EOL gets highlighted to indicate that fact.





  reply	other threads:[~2020-01-31 15:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-30 21:08 bug#39360: Add :extend attribute to show-paren-mode expression face Clément Pit-Claudel
2020-01-30 23:35 ` Dmitry Gutov
2020-01-31  7:38 ` Eli Zaretskii
2020-01-31 14:52   ` Clément Pit-Claudel
2020-01-31 15:32     ` Eli Zaretskii [this message]
2020-01-31 15:51       ` Clément Pit-Claudel
2020-01-31 17:03         ` Eli Zaretskii
2020-02-07  0:27           ` Dmitry Gutov
2020-02-07  0:40             ` Juri Linkov
2020-02-07  8:13               ` Eli Zaretskii
2020-02-07  8:02             ` Eli Zaretskii
2020-01-31 15:44     ` martin rudalics
2020-01-31 15:55       ` Eli Zaretskii
2020-01-31 16:12         ` Clément Pit-Claudel
2020-01-31 17:12           ` Eli Zaretskii
2020-01-31 17:19             ` Dmitry Gutov
2020-01-31 19:19               ` Eli Zaretskii
2020-01-31 17:22             ` Eli Zaretskii
2020-02-01 20:54               ` Clément Pit-Claudel
2020-01-31 16:45         ` martin rudalics
2020-01-31 16:03     ` Stephen Berman
2020-01-31 16:45       ` martin rudalics
2020-01-31 17:15         ` Eli Zaretskii
2020-01-31 17:07       ` Eli Zaretskii
2020-01-31 16:07     ` Stephen Berman
2020-09-20 10:01 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834kwbljz9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=39360@debbugs.gnu.org \
    --cc=cpitclaudel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).