From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#39380: 26.3: Opening files in vc-dir-mode with differing root and working dir fails Date: Fri, 07 Feb 2020 11:53:32 +0200 Message-ID: <834kw2g1ur.fsf@gnu.org> References: <8eea69d2-46ed-0c41-b516-0120251dcc96@gmx.de> <504aedd0-54e5-aa62-b19f-41fbafa9aa17@gmx.de> <09ef5fcb-80b7-3b43-243a-2278b46281ba@yandex.ru> <5c7d9eab-59d1-21c1-c8e5-1c820cb2946b@gmx.de> <25183dd6-10b3-c3c4-0910-262c70434161@gmx.de> <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="80997"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 39380@debbugs.gnu.org, Wolfgang.Scherer@gmx.de To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 07 10:54:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j00Kx-000KyK-DM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 10:54:11 +0100 Original-Received: from localhost ([::1]:53052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j00Kw-0003qc-5J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Feb 2020 04:54:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39704) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j00Kp-0003qO-Dk for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:54:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j00Ko-0005Fx-FY for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:54:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42930) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j00Ko-0005FN-CV for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j00Ko-0001zW-9w for bug-gnu-emacs@gnu.org; Fri, 07 Feb 2020 04:54:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Feb 2020 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39380 X-GNU-PR-Package: emacs Original-Received: via spool by 39380-submit@debbugs.gnu.org id=B39380.15810692407647 (code B ref 39380); Fri, 07 Feb 2020 09:54:02 +0000 Original-Received: (at 39380) by debbugs.gnu.org; 7 Feb 2020 09:54:00 +0000 Original-Received: from localhost ([127.0.0.1]:48903 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j00Km-0001zH-8u for submit@debbugs.gnu.org; Fri, 07 Feb 2020 04:54:00 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j00Kk-0001yv-Qe for 39380@debbugs.gnu.org; Fri, 07 Feb 2020 04:53:59 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1j00Kf-00052m-37; Fri, 07 Feb 2020 04:53:53 -0500 Original-Received: from [176.228.60.248] (port=3909 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1j00Ke-00017B-CW; Fri, 07 Feb 2020 04:53:52 -0500 In-reply-to: <0a8b11c8-1c5c-33ed-e5a1-e7ad5b090929@yandex.ru> (message from Dmitry Gutov on Thu, 6 Feb 2020 16:38:54 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175743 Archived-At: > Cc: Eli Zaretskii > From: Dmitry Gutov > Date: Thu, 6 Feb 2020 16:38:54 +0300 > > >> Good catch, thank you. Could you try this patch? > >> > > Works fine. Directory listing in vc-dir-mode is truncated at sub-directory. Files are processed correctly. > > Very good. > > Eli, I'd like to get it into emacs-27. OK? I'll have to ask you to walk me through the change and explain how it solves the original issue. I tried to figure that out myself, but it's too hard: the patch has no log message, the function being changed has no doc string which could describe its contract, and the Mercurial documentation I've read seems to contradict what you are doing (e.g., it says "re:" should be immediately followed by a regexp). Sorry, I cannot make up my mind whether this is a safe change without understanding it better. Thanks.