From: Eli Zaretskii <eliz@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 39962@debbugs.gnu.org, pieter-l@vanoostrum.org, eggert@cs.ucla.edu
Subject: bug#39962: 27.0.90; Crash in Emacs 27.0.90
Date: Wed, 11 Mar 2020 21:34:26 +0200 [thread overview]
Message-ID: <834kuuadod.fsf@gnu.org> (raw)
In-Reply-To: <CAOqdjBeTusDtxc9fug+V8XraxO0P_nu2GctBO5dq60Fdz_cE8Q@mail.gmail.com> (message from Pip Cet on Wed, 11 Mar 2020 18:53:55 +0000)
> From: Pip Cet <pipcet@gmail.com>
> Date: Wed, 11 Mar 2020 18:53:55 +0000
> Cc: pieter-l@vanoostrum.org, 39962@debbugs.gnu.org, eggert@cs.ucla.edu
>
> > Did you audit all the users of this function, both direct and
> > indirect? Some of them are outside of GC.
>
> Thanks for the comment; I just re-checked, and they look fine to me.
??? Fine in what way? One of the callers is live_buffer_p, which is
called by valid_lisp_object_p, which is expected to return a special
value for dead buffers. Your change will break that, no?
IOW, you are changing the semantics of "live buffer", for a reason
that can hardly justify that. That doesn't sound economical to me; it
will certainly make it much harder for me to agree to make the change
on the release branch. The problem you are trying to solve is rare
and obscure, since this code was with us since 20 years ago without
anyone bumping into it, so changing it to solve such a rare problem,
and on the release branch on top of that, doesn't sound right to me.
Am I missing something?
next prev parent reply other threads:[~2020-03-11 19:34 UTC|newest]
Thread overview: 119+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 23:55 bug#39962: 27.0.90; Crash in Emacs 27.0.90 Pieter van Oostrum
2020-03-07 7:48 ` Eli Zaretskii
2020-03-07 8:40 ` Pieter van Oostrum
2020-03-07 8:41 ` Pieter van Oostrum
2020-03-07 10:51 ` Eli Zaretskii
2020-03-07 11:06 ` Pieter van Oostrum
2020-03-07 13:10 ` Eli Zaretskii
2020-03-07 15:06 ` Pieter van Oostrum
2020-03-07 15:17 ` Eli Zaretskii
2020-03-07 15:49 ` Pieter van Oostrum
2020-03-07 16:07 ` Eli Zaretskii
2020-03-07 17:21 ` Pieter van Oostrum
2020-03-07 18:01 ` Eli Zaretskii
2020-03-07 19:14 ` Pieter van Oostrum
2020-03-07 19:21 ` Eli Zaretskii
2020-03-07 22:07 ` Pieter van Oostrum
2020-03-09 4:00 ` Pip Cet
2020-03-08 7:42 ` Paul Eggert
2020-03-08 9:34 ` Pieter van Oostrum
2020-03-08 10:05 ` Paul Eggert
2020-03-08 21:37 ` Pieter van Oostrum
2020-03-08 21:58 ` Pieter van Oostrum
2020-03-08 22:34 ` Paul Eggert
2020-03-08 23:58 ` Pieter van Oostrum
2020-03-09 0:01 ` Paul Eggert
2020-03-09 13:26 ` Pieter van Oostrum
2020-03-09 17:10 ` Eli Zaretskii
2020-03-09 19:48 ` Pieter van Oostrum
2020-03-10 13:37 ` Pieter van Oostrum
2020-03-09 19:51 ` Paul Eggert
2020-03-09 21:32 ` Pieter van Oostrum
2020-03-10 10:52 ` Pieter van Oostrum
2020-03-10 14:19 ` Pip Cet
2020-03-10 16:36 ` Pieter van Oostrum
2020-03-11 14:32 ` Pip Cet
2020-03-11 15:16 ` Pieter van Oostrum
2020-03-11 15:43 ` Pip Cet
2020-03-11 15:51 ` Paul Eggert
2020-03-11 16:21 ` Eli Zaretskii
2020-03-11 17:52 ` Eli Zaretskii
2020-03-11 18:53 ` Pip Cet
2020-03-11 19:34 ` Eli Zaretskii [this message]
2020-03-12 10:32 ` Pip Cet
2020-03-12 15:23 ` Eli Zaretskii
2020-03-12 20:36 ` Pip Cet
2020-03-13 9:39 ` Eli Zaretskii
2020-03-13 13:56 ` Pip Cet
2020-03-13 16:30 ` Eli Zaretskii
2020-03-14 9:02 ` Pip Cet
2020-03-14 15:39 ` Pip Cet
2020-03-14 16:00 ` Paul Eggert
2020-03-14 16:15 ` Pip Cet
2020-03-14 16:57 ` Eli Zaretskii
2020-03-14 18:34 ` Pip Cet
2020-03-14 19:09 ` Paul Eggert
2020-03-14 20:10 ` Eli Zaretskii
2020-03-15 12:12 ` Pip Cet
2020-03-15 14:53 ` Eli Zaretskii
2020-03-15 12:09 ` Pip Cet
2020-03-15 14:50 ` Eli Zaretskii
2020-03-16 16:31 ` Stefan Monnier
2020-03-11 20:03 ` Pieter van Oostrum
2020-03-12 13:55 ` Pip Cet
2020-03-12 18:13 ` Pieter van Oostrum
2020-03-12 20:00 ` Pip Cet
2020-03-13 8:09 ` Eli Zaretskii
2020-03-13 8:39 ` Pip Cet
2020-03-13 9:19 ` Eli Zaretskii
2020-03-13 17:43 ` Pieter van Oostrum
2020-03-14 3:38 ` Richard Stallman
2020-03-14 8:37 ` Eli Zaretskii
2020-03-14 9:16 ` Pip Cet
2020-03-14 15:34 ` Pip Cet
2020-03-13 17:42 ` Pieter van Oostrum
2020-03-13 19:34 ` Eli Zaretskii
2020-03-13 21:35 ` Pieter van Oostrum
2020-03-14 8:08 ` Eli Zaretskii
2020-03-14 21:32 ` Pieter van Oostrum
2020-03-15 19:49 ` Pieter van Oostrum
2020-03-15 19:57 ` Eli Zaretskii
2020-03-15 23:26 ` Pieter van Oostrum
2020-03-16 10:44 ` Pieter van Oostrum
2020-03-16 15:07 ` Eli Zaretskii
2020-03-16 15:33 ` Pip Cet
2020-03-16 17:19 ` Pip Cet
2020-03-17 3:29 ` Pieter van Oostrum
2020-03-17 4:54 ` Pip Cet
2020-03-17 5:20 ` Pip Cet
2020-03-17 8:45 ` Pieter van Oostrum
2020-03-17 13:54 ` Pip Cet
2020-03-17 15:27 ` Pieter van Oostrum
2020-03-17 20:16 ` Pip Cet
2020-03-17 23:32 ` Pieter van Oostrum
2020-03-18 15:05 ` Eli Zaretskii
2020-03-19 13:23 ` Pieter van Oostrum
2020-03-19 13:57 ` Pip Cet
2020-03-21 21:22 ` Pieter van Oostrum
2020-03-22 14:21 ` Eli Zaretskii
2020-03-22 15:48 ` Pip Cet
2020-03-23 19:34 ` Pip Cet
2020-03-17 8:40 ` Pieter van Oostrum
2020-03-17 15:33 ` Eli Zaretskii
2020-03-17 20:59 ` Paul Eggert
2020-03-18 6:17 ` Pip Cet
2020-03-18 9:22 ` Robert Pluim
2020-03-18 11:38 ` Pieter van Oostrum
2020-03-18 11:57 ` Paul Eggert
2020-03-18 14:08 ` Pip Cet
2020-03-19 19:17 ` Pieter van Oostrum
2020-03-19 19:31 ` Pip Cet
2020-03-19 21:30 ` Pieter van Oostrum
2020-03-18 14:08 ` Eli Zaretskii
2020-03-16 18:36 ` Pieter van Oostrum
2020-03-13 7:58 ` Eli Zaretskii
2020-03-10 15:10 ` Eli Zaretskii
2020-03-10 18:23 ` Pieter van Oostrum
2020-03-11 8:22 ` Paul Eggert
2022-04-30 12:38 ` Lars Ingebrigtsen
2022-05-29 13:19 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834kuuadod.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=39962@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=pieter-l@vanoostrum.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).