From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#40845: SVG rendering issues Date: Sun, 03 May 2020 22:17:49 +0300 Message-ID: <834kswq142.fsf@gnu.org> References: <17307310-2afc-7941-8a48-5cd345d1ad63@gmail.com> <83k1237b2a.fsf@gnu.org> <20200425174651.GC82687@breton.holly.idiocy.org> <20200426211741.GA93046@breton.holly.idiocy.org> <09a19c49-91cb-8024-8c34-53d846d98313@gmail.com> <20200503141348.GA4071@breton.holly.idiocy.org> <83r1w1ovc3.fsf@gnu.org> <83ftchotee.fsf@gnu.org> <20200503183839.GA24860@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="24102"; mail-complaints-to="usenet@ciao.gmane.io" Cc: cpitclaudel@gmail.com, 40845@debbugs.gnu.org, pipcet@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 03 21:19:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jVK8r-0006B5-Nm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 21:19:09 +0200 Original-Received: from localhost ([::1]:50160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVK8q-0001ai-KS for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 May 2020 15:19:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jVK8k-0001Xf-00 for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 15:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jVK8j-0007tS-N5 for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 15:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jVK8j-0005Wc-Jm for bug-gnu-emacs@gnu.org; Sun, 03 May 2020 15:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2020 19:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40845 X-GNU-PR-Package: emacs Original-Received: via spool by 40845-submit@debbugs.gnu.org id=B40845.158853348421173 (code B ref 40845); Sun, 03 May 2020 19:19:01 +0000 Original-Received: (at 40845) by debbugs.gnu.org; 3 May 2020 19:18:04 +0000 Original-Received: from localhost ([127.0.0.1]:58043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVK7o-0005VR-1J for submit@debbugs.gnu.org; Sun, 03 May 2020 15:18:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jVK7m-0005Uy-Uh for 40845@debbugs.gnu.org; Sun, 03 May 2020 15:18:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58489) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jVK7h-0006IV-4t; Sun, 03 May 2020 15:17:57 -0400 Original-Received: from [176.228.60.248] (port=2758 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jVK7g-0000Hd-JQ; Sun, 03 May 2020 15:17:56 -0400 In-Reply-To: <20200503183839.GA24860@breton.holly.idiocy.org> (message from Alan Third on Sun, 3 May 2020 19:38:39 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:179608 Archived-At: > Date: Sun, 3 May 2020 19:38:39 +0100 > From: Alan Third > Cc: cpitclaudel@gmail.com, 40845@debbugs.gnu.org, pipcet@gmail.com > > > > One thing is that it gets the foreground colour from the default face > > > instead of the current face. I’m not sure how to solve that. > > > > Can you describe the difficulty in using the current face? > > I’m mostly unsure how I access it. I don’t think images or image.c > have any real concept of where they are in the buffer. When the 'load' method (in your case, svg_load) is called from prepare_image_for_display, we have the face information handy. Usually, at that point we don't call the 'load' method, because the image is already loaded and cached. But we could change the logic if we know that the image must be modified to have a different face. Then we can pass the color information to the 'load' method. > I think we’d also have to recreate the image any time the face > changed. Yes, because changing the color(s) makes a different image. But that is not a problem, I think. > I feel it would be easier just to have two or more cached images with > different foreground and backgrounds as required. Agreed. At least as the first approximation; we could always change that later if we find this not to be good enough.