From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41232: [PATCH] Avoid a segfault when processing disable-eval specs Date: Wed, 13 May 2020 18:54:35 +0300 Message-ID: <834ksj7rus.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108338"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41232-done@debbugs.gnu.org To: =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 13 17:55:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYtix-000S5R-4N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 17:55:11 +0200 Original-Received: from localhost ([::1]:34400 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYtiw-0000WQ-4p for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 May 2020 11:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42210) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYtio-0000U1-T1 for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 11:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47592) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jYtio-0007c1-Js for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 11:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jYtio-0006Xz-JQ for bug-gnu-emacs@gnu.org; Wed, 13 May 2020 11:55:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 May 2020 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 41232 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 41232@debbugs.gnu.org, eliz@gnu.org, cpitclaudel@gmail.com Original-Received: via spool by 41232-done@debbugs.gnu.org id=D41232.158938530025152 (code D ref 41232); Wed, 13 May 2020 15:55:02 +0000 Original-Received: (at 41232-done) by debbugs.gnu.org; 13 May 2020 15:55:00 +0000 Original-Received: from localhost ([127.0.0.1]:59137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYtim-0006Xc-4O for submit@debbugs.gnu.org; Wed, 13 May 2020 11:55:00 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jYtik-0006XQ-Tg for 41232-done@debbugs.gnu.org; Wed, 13 May 2020 11:54:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40026) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYtif-0007Yv-HB; Wed, 13 May 2020 11:54:53 -0400 Original-Received: from [176.228.60.248] (port=3769 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jYtif-0000By-2X; Wed, 13 May 2020 11:54:53 -0400 In-Reply-To: (message from =?UTF-8?Q?Cl=C3=A9ment?= Pit-Claudel on Wed, 13 May 2020 10:40:18 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:180161 Archived-At: > From: Clément Pit-Claudel > Date: Wed, 13 May 2020 10:40:18 -0400 > > The following code causes Emacs to segfault: > > (insert (propertize "A" 'display '(disable-eval . nil))) > > This is due to this code, which takes an XCAR without checking whether the spec is a cons: > > /* Support (disable-eval PROP) which is used by enriched.el. */ > if (CONSP (spec) && EQ (XCAR (spec), Qdisable_eval)) > { > enable_eval = false; > spec = XCAR (XCDR (spec)); > } > > The attached patch fixes this. Thanks, installed.