From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#26911: 25.2; eshell "cd .." doesn't work correctly with TRAMP Date: Sat, 05 Sep 2020 19:33:27 +0300 Message-ID: <834kocp4iw.fsf@gnu.org> References: <83sgc7z220.fsf@gnu.org> <83r1rryrk0.fsf@gnu.org> <47047d69-91aa-fd0d-1510-64ba7c246970@cs.ucla.edu> <83a6yeynd1.fsf@gnu.org> <03a31052-795a-c169-c199-2b0f3ba88ec2@cs.ucla.edu> <83sgc5xq8k.fsf@gnu.org> <164450fe-7f86-e336-87d4-13c52e52c61c@cs.ucla.edu> <83eenoxm18.fsf@gnu.org> <6acf8cfa-6071-e7b1-3055-04292634bb39@cs.ucla.edu> <83sgc2x3p2.fsf@gnu.org> <83imcuvkhd.fsf@gnu.org> <871rjhsqmr.fsf@gmx.de> <83lfhpu3st.fsf@gnu.org> <87wo19r6m2.fsf@gmx.de> <83eenhtxjv.fsf@gnu.org> <87r1rhr0rw.fsf@gmx.de> <838sdpqw07.fsf@gnu.org> <87363wr59c.fsf@gmx.de> <83lfhopj3t.fsf@gnu.org> <87zh64tdvf.fsf@gmx.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3372"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 26911@debbugs.gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, yegortimoshenko@gmail.com To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 18:34:32 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEb95-0000lA-Nh for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 18:34:31 +0200 Original-Received: from localhost ([::1]:50684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEb94-0007em-Gt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 12:34:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53354) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEb8d-0007RE-Jb for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEb8c-0002vQ-Hi for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:34:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEb8c-00067u-E0 for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26911 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 26911-submit@debbugs.gnu.org id=B26911.159932362523528 (code B ref 26911); Sat, 05 Sep 2020 16:34:02 +0000 Original-Received: (at 26911) by debbugs.gnu.org; 5 Sep 2020 16:33:45 +0000 Original-Received: from localhost ([127.0.0.1]:43958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEb8L-00067Q-9L for submit@debbugs.gnu.org; Sat, 05 Sep 2020 12:33:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEb8I-00067B-TP for 26911@debbugs.gnu.org; Sat, 05 Sep 2020 12:33:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:36176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEb8C-0002te-MG; Sat, 05 Sep 2020 12:33:36 -0400 Original-Received: from [176.228.60.248] (port=2038 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEb8B-0001yW-BO; Sat, 05 Sep 2020 12:33:36 -0400 In-Reply-To: <87zh64tdvf.fsf@gmx.de> (message from Michael Albinus on Sat, 05 Sep 2020 17:57:56 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187277 Archived-At: > From: Michael Albinus > Cc: 26911@debbugs.gnu.org, mattiase@acm.org, eggert@cs.ucla.edu, > yegortimoshenko@gmail.com > Date: Sat, 05 Sep 2020 17:57:56 +0200 > > > Is it possible to make sure these processes are killed as part of each > > test's cleanup? For now, I ran the tests one by one, each time > > killing the zombie processes manually on the remote system. It took > > some time... > > Most of the tests start with (skip-unless (tramp--test-enabled)). This > defun calls tramp-cleanup-connection, which shall also kill all related > Tramp processes. Doesn't seem to work on MS Windows. AFAICS, tramp-cleanup-connection deletes the network connection processes, but is that supposed to make sure the other side of the connection exits cleanly? > Hard to debug for me w/o such a machine. Could you write a bug report as > a reminder for me, that I investigate when I have such a machine? Will do. And let me know if I can provide more details about this matter, or help you debug this. > > Test tramp-test30-make-process condition: > > (ert-test-failed > > ((should > > (string-match > > (if ... "unknown signal > > \\'" "killed.* > > \\'") > > (buffer-string))) > > :form > > (string-match "unknown signal > > \\'" "killed > > ") > > :value nil)) > > FAILED 1/1 tramp-test30-make-process (39.250000 sec) > > > > Just to be sure, I've ran this test twice, and each time it failed > > with the same error. > > Hahh! There is a special case in that test for MS-Windows: > > --8<---------------cut here---------------start------------->8--- > (should > (string-match > (if (eq system-type 'windows-nt) > "unknown signal\n\\'" "killed.*\n\\'") > (buffer-string)))) > --8<---------------cut here---------------end--------------->8--- > > IIRC, somebody has reported this different return message. Or maybe I > have seen this on the MS Windows machine I've used for testing. > > Maybe we shall simply allow both messages, because the exact wording > doesn't matter. What about the appended patch? It fixes the problem, thanks.