From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44494: etags.el xref-location-marker does not handle TAGS references to .el.gz files Date: Sat, 07 Nov 2020 17:52:43 +0200 Message-ID: <834km16u5w.fsf@gnu.org> References: <1cdac9f7-8340-83eb-f619-583e028e6e23@yandex.ru> <83wnyx7g0u.fsf@gnu.org> <838sbd6xn1.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44494@debbugs.gnu.org, dgutov@yandex.ru To: Pierre Rouleau Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 07 16:53:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kbQWb-0009uT-H6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 16:53:09 +0100 Original-Received: from localhost ([::1]:33094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbQWa-0001zT-GR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Nov 2020 10:53:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbQWU-0001z7-4t for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:53:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47583) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kbQWT-0008Dl-RW for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:53:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kbQWT-00017w-QY for bug-gnu-emacs@gnu.org; Sat, 07 Nov 2020 10:53:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Nov 2020 15:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44494 X-GNU-PR-Package: emacs Original-Received: via spool by 44494-submit@debbugs.gnu.org id=B44494.16047643714315 (code B ref 44494); Sat, 07 Nov 2020 15:53:01 +0000 Original-Received: (at 44494) by debbugs.gnu.org; 7 Nov 2020 15:52:51 +0000 Original-Received: from localhost ([127.0.0.1]:59129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbQWI-00017X-Qj for submit@debbugs.gnu.org; Sat, 07 Nov 2020 10:52:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbQWG-00017K-2g for 44494@debbugs.gnu.org; Sat, 07 Nov 2020 10:52:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60249) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbQWA-00086Y-LH; Sat, 07 Nov 2020 10:52:42 -0500 Original-Received: from [176.228.60.248] (port=1594 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbQW9-00071X-VX; Sat, 07 Nov 2020 10:52:42 -0500 In-Reply-To: (message from Pierre Rouleau on Sat, 7 Nov 2020 10:39:41 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192842 Archived-At: > From: Pierre Rouleau > Date: Sat, 7 Nov 2020 10:39:41 -0500 > Cc: dgutov@yandex.ru, 44494@debbugs.gnu.org > > One difference is that when using find-tag is using code from etags.el exclusively: > - find-tag-noselect > . - find-tag-in-order , which tries different predicates and the one that succeeds is > tag-implicit-name-match-p > . - it identifies the cc-bytecomp.el.gz > .- calls etags-goto-tag-location The Xref etags backend also uses tag-implicit-name-match-p: (defvar etags-xref-find-definitions-tag-order '(tag-exact-match-p tag-implicit-name-match-p) "Tag order used in `xref-backend-definitions' to look for definitions. If you want `xref-find-definitions' to find the tagged files by their file name, add `tag-partial-file-name-match-p' to the list value.") > When using xref-find-definition the xref backend is used. It's not the same code. > The xref backend code for elisp does not find it. The backend code for etags does not find it either. > It tries to open cc-bytecomp.el as its the file name it gets from the TAGS file. > It detects the file not being present and reports it as missing, assuming the file have been removed. > > To me the 2 sets of code look very different. They share some of the code, at least when xref-etags-mode is used. So it sounds like some information found by tag-implicit-name-match-p doesn't get handed back to Xref? For the Xref's own ELisp backend, we will probably need to code something in xref.el.