unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: thamer.mahmoud@gmail.com
Cc: 44521@debbugs.gnu.org
Subject: bug#44521: 27.1; ivy.el breaks harfbuzz Arabic shaping
Date: Mon, 09 Nov 2020 17:25:09 +0200	[thread overview]
Message-ID: <834kly5z8q.fsf@gnu.org> (raw)
In-Reply-To: <83k0uv69zw.fsf@gnu.org> (message from Eli Zaretskii on Sun, 08 Nov 2020 19:20:35 +0200)

> Date: Sun, 08 Nov 2020 19:20:35 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 44521@debbugs.gnu.org
> 
> > From: Thamer Mahmoud <thamer.mahmoud@gmail.com>
> > Date: Sun, 08 Nov 2020 19:15:37 +0300
> > 
> > (progn
> >   (load-library "~/.emacs.d/elpa/ivy-0.13.0/ivy-overlay.el")
> >   (load-library "~/.emacs.d/elpa/ivy-0.13.0/colir.el")
> >   (load-library "~/.emacs.d/elpa/ivy-0.13.0/ivy.el")
> >   (ivy-mode t)
> >   (run-with-timer .5 nil 'set-input-method "arabic")
> >   (run-with-timer .5 nil 'insert "السلام عليكم")
> >   (execute-extended-command nil))
> > 
> > 2. While still in the minibuffer, type any Arabic letter. Note the
> >    AIN(ع) in "عليكم" changes shape from initial to final.
> > 
> > This bug breaks shaping in most buffers, especially after using
> > swiper.el (ivy-based isearch).
> 
> I'm not familiar with ivy, but if it writes the text in the minibuffer
> in several overlays, then the Arabic text will indeed become
> disconnected and generally shaped incorrectly.
> 
> I'll try to look into this, but to make this easier and more efficient
> I'd appreciate a test case that is less complicated, preferably not
> using ivy at all.

Actually, it turned out that the reason is very clear, thanks for the
recipe which made it so easy.  So I've now fixed this on the emacs-27
branch for the upcoming Emacs 27.2.





  reply	other threads:[~2020-11-09 15:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-08 16:15 bug#44521: 27.1; ivy.el breaks harfbuzz Arabic shaping Thamer Mahmoud
2020-11-08 17:20 ` Eli Zaretskii
2020-11-09 15:25   ` Eli Zaretskii [this message]
2020-11-10  9:19     ` Thamer Mahmoud
2020-11-10 15:54       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834kly5z8q.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44521@debbugs.gnu.org \
    --cc=thamer.mahmoud@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).