* bug#22299: Obsolete selective-display
[not found] <7j8u467a11.fsf@fencepost.gnu.org>
@ 2019-03-18 16:09 ` Glenn Morris
2021-01-21 16:56 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2019-03-18 16:09 UTC (permalink / raw)
To: 22299
Perhaps this is done as of 2f50a99 and similar.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22299: Obsolete selective-display
2019-03-18 16:09 ` bug#22299: Obsolete selective-display Glenn Morris
@ 2021-01-21 16:56 ` Lars Ingebrigtsen
2021-01-21 17:14 ` Stefan Monnier
2021-01-21 19:42 ` Eli Zaretskii
0 siblings, 2 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-21 16:56 UTC (permalink / raw)
To: Glenn Morris; +Cc: Stefan Monnier, 22299
Glenn Morris <rgm@gnu.org> writes:
> Perhaps this is done as of 2f50a99 and similar.
The `selective-display' variable isn't marked as deprecated, though, and
is used throughout Emacs... should is be marked as such? And the
usages either removed (from the callers) or warnings suppressed (in
simple.el etc).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22299: Obsolete selective-display
2021-01-21 16:56 ` Lars Ingebrigtsen
@ 2021-01-21 17:14 ` Stefan Monnier
2021-01-22 17:22 ` Lars Ingebrigtsen
2021-01-21 19:42 ` Eli Zaretskii
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Monnier @ 2021-01-21 17:14 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Glenn Morris, 22299
>> Perhaps this is done as of 2f50a99 and similar.
> The `selective-display' variable isn't marked as deprecated, though, and
> is used throughout Emacs...
I don't think it's *used* throughout. AFAIK it's *obeyed* at many
places, in case someone still uses it (it's obsolete, not removed).
If you spot an actual use, please report it as a bug.
> should it be marked as such? And the usages either removed (from the
> callers) or warnings suppressed (in simple.el etc).
The problem is that the var has 2 uses:
- one is the obsolete value `t` whereby \r.* is hidden
- the other is when it's set to an integer N whereby it hides lines with
a deeper indentation than N.
The second one is a UI functionality and it's sufficiently "not terribly
useful" that nobody bothered to write a replacement for it using
overlays (instead, all the possible replacements provide a more tailored
functionality).
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22299: Obsolete selective-display
2021-01-21 16:56 ` Lars Ingebrigtsen
2021-01-21 17:14 ` Stefan Monnier
@ 2021-01-21 19:42 ` Eli Zaretskii
1 sibling, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2021-01-21 19:42 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: rgm, monnier, 22299
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Thu, 21 Jan 2021 17:56:22 +0100
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 22299@debbugs.gnu.org
>
> Glenn Morris <rgm@gnu.org> writes:
>
> > Perhaps this is done as of 2f50a99 and similar.
>
> The `selective-display' variable isn't marked as deprecated, though, and
> is used throughout Emacs... should is be marked as such?
I use set-selective-display all the time, so I'd be unhappy if it were
obsoleted, FWIW.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22299: Obsolete selective-display
2021-01-21 17:14 ` Stefan Monnier
@ 2021-01-22 17:22 ` Lars Ingebrigtsen
2021-01-22 17:55 ` Stefan Monnier
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-01-22 17:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: Glenn Morris, 22299
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> should it be marked as such? And the usages either removed (from the
>> callers) or warnings suppressed (in simple.el etc).
>
> The problem is that the var has 2 uses:
> - one is the obsolete value `t` whereby \r.* is hidden
> - the other is when it's set to an integer N whereby it hides lines with
> a deeper indentation than N.
Oh, I see. I should have read that node in the manual. :-)
Anyway, I've grepped through the Emacs tree, and I can't find any places
where we're binding/setting `selective-display' to t, so there indeed
doesn't seem to be any usages of the obsolete form.
> The second one is a UI functionality and it's sufficiently "not terribly
> useful" that nobody bothered to write a replacement for it using
> overlays (instead, all the possible replacements provide a more tailored
> functionality).
Right. So if we don't want to obsolete the other form (and Eli says he
uses it all the time, so it doesn't sound like we want to), then I guess
there's nothing more to be done here? So I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#22299: Obsolete selective-display
2021-01-22 17:22 ` Lars Ingebrigtsen
@ 2021-01-22 17:55 ` Stefan Monnier
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2021-01-22 17:55 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Glenn Morris, 22299
>> The second one is a UI functionality and it's sufficiently "not terribly
>> useful" that nobody bothered to write a replacement for it using
>> overlays (instead, all the possible replacements provide a more tailored
>> functionality).
> Right. So if we don't want to obsolete the other form (and Eli says he
> uses it all the time, so it doesn't sound like we want to), then I guess
> there's nothing more to be done here? So I'm closing this bug report.
We could try and re-implement `set-selective-display` using overlays,
of course.
And we could try and provide some other "text hiding" package more
specifically tailored to Eli's uses.
But really, I don't mind the `set-selective-display` feature now how
it's currently implemented, so I don't see a strong need to
replace/obsolete it.
The "selective-display == t" case is the one I care about because it
causes (well, "caused" since we started to drop that kind of
compatibility code) complexity in packages which had to deal with "end
of line can also be \r".
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-22 17:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <7j8u467a11.fsf@fencepost.gnu.org>
2019-03-18 16:09 ` bug#22299: Obsolete selective-display Glenn Morris
2021-01-21 16:56 ` Lars Ingebrigtsen
2021-01-21 17:14 ` Stefan Monnier
2021-01-22 17:22 ` Lars Ingebrigtsen
2021-01-22 17:55 ` Stefan Monnier
2021-01-21 19:42 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).