From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46859: 28.0.50; [PATCH]: Add option to truncate long lines in xref.el Date: Thu, 04 Mar 2021 19:13:16 +0200 Message-ID: <834khq266r.fsf@gnu.org> References: <87im69uzlt.fsf@mail.linkov.net> <878s74fv27.fsf@mail.linkov.net> <4119ea3055ef8f306fc0@heytings.org> <4119ea30557ef84ca190@heytings.org> <7eb7ee0f-7dba-c90d-cb58-af42c3828643@yandex.ru> <4119ea30554b406efbbf@heytings.org> <4119ea30558f1e4145b0@heytings.org> <4119ea30555e80bdcf7e@heytings.org> <1c82e582-8b90-f3c5-5391-1e88ca4e7ab2@yandex.ru> <4119ea30553e3f90ab8c@heytings.org> <87y2f42ex5.fsf@mail.linkov.net> <4119ea30552873ab9870@heytings.org> <83eegvk2u0.fsf@gnu.org> <9cff0f8894658f3b50c8@heytings.org> <83y2f3huz2.fsf@gnu.org> <9cff0f88942d4103c685@heytings.org> <83mtvjhrzj.fsf@gnu.org> <9cff0f889435d8d03313@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46859@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 04 18:15:28 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHrZP-0009fQ-N6 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 18:15:27 +0100 Original-Received: from localhost ([::1]:35350 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHrZO-0006np-M2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 04 Mar 2021 12:15:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHrY2-0005nr-3N for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 12:14:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lHrY1-0008Pp-SA for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 12:14:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lHrY1-00028l-LC for bug-gnu-emacs@gnu.org; Thu, 04 Mar 2021 12:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Mar 2021 17:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46859 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 46859-submit@debbugs.gnu.org id=B46859.16148780238196 (code B ref 46859); Thu, 04 Mar 2021 17:14:01 +0000 Original-Received: (at 46859) by debbugs.gnu.org; 4 Mar 2021 17:13:43 +0000 Original-Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHrXi-000287-RC for submit@debbugs.gnu.org; Thu, 04 Mar 2021 12:13:43 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57506) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lHrXh-00027u-CR for 46859@debbugs.gnu.org; Thu, 04 Mar 2021 12:13:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37131) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHrXa-0008F6-Em; Thu, 04 Mar 2021 12:13:35 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3359 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lHrXZ-0003yA-Iq; Thu, 04 Mar 2021 12:13:34 -0500 In-Reply-To: <9cff0f889435d8d03313@heytings.org> (message from Gregory Heytings on Thu, 04 Mar 2021 16:47:30 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201414 Archived-At: > Date: Thu, 04 Mar 2021 16:47:30 +0000 > From: Gregory Heytings > cc: 46859@debbugs.gnu.org > > > Yes. But it can be slow. > > Can it become so slow that it would have an impact on user experience? I don't know, Grep is a somewhat special application. > filepos-to-bufferpos would be called only when the xref link is followed, > so I guess that even a 0.1 or 0.2 second delay should be okay. Yes, 0.1 sec is definitely okay. > I just tried again on a 25 MB Latin-1 file, on one of the last bytes it > took ~13 ms without specifying a quality. I tried with nil, 'approximate > and 'best, but do not see any difference, the result with benchmark-run is > always ~13 ms. > > > Also, what happens with multibyte encodings that are not UTF-8, like > > iso-2022, for example? > > Well, the Latin-1 file is already different from UTF-8. AFAIR, with single-byte encoding we take a shortcut there. > I don't know anything about ISO-2022, but tried with a 25 MB file, created > with iconv, which Emacs recognizes as an iso-2022-7bit-dos one. In that > case filepos-to-bufferpos does not work at all, with 'approximate you get > a position that is about 2 million characters away from the correct one, > and with 'best or nil you get nil... Not 'best, 'exact. Did you try 'exact? It should have worked, barring any bugs.