From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#46055: [PATCH] Add rust lang to etags Date: Mon, 17 May 2021 18:51:55 +0300 Message-ID: <834kf1tl2c.fsf@gnu.org> References: <20210125143344.21837-1-contact@parouby.fr> <87im4fvfye.fsf@tucano.isti.cnr.it> <87sg2lidtr.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="941"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, contact@parouby.fr, 46055@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 17 17:53:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lifYO-000AYO-VW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 17:53:12 +0200 Original-Received: from localhost ([::1]:59642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lifYN-0002jR-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 17 May 2021 11:53:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51166) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lifYE-0002fR-MI for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lifYE-00048N-Dx for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lifYE-0007uu-Cr for bug-gnu-emacs@gnu.org; Mon, 17 May 2021 11:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 May 2021 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46055 X-GNU-PR-Package: emacs Original-Received: via spool by 46055-submit@debbugs.gnu.org id=B46055.162126672530357 (code B ref 46055); Mon, 17 May 2021 15:53:02 +0000 Original-Received: (at 46055) by debbugs.gnu.org; 17 May 2021 15:52:05 +0000 Original-Received: from localhost ([127.0.0.1]:53595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifXJ-0007tZ-J5 for submit@debbugs.gnu.org; Mon, 17 May 2021 11:52:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lifXH-0007sx-8H for 46055@debbugs.gnu.org; Mon, 17 May 2021 11:52:04 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48468) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lifX9-0003Zd-Ci; Mon, 17 May 2021 11:51:57 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1890 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lifX6-0000Ey-Rj; Mon, 17 May 2021 11:51:54 -0400 In-Reply-To: <87sg2lidtr.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 17 May 2021 17:23:44 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206729 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 17 May 2021 17:23:44 +0200 > Cc: Stefan Kangas , > Pierre-Antoine Rouby , 46055@debbugs.gnu.org > > Francesco Potortì writes: > > >>I have one question, though. In "test/manual/etags", we have manual > >>tests for etags including source code examples and which tags they > >>should generate. Should we add a manual test also for Rust? > > > > I'd say definitely yes. Ideally, the regression tests should be updated > > every time a new feature is added or a bug is corrected. > > I looked into adding a Rust test there... but it's unclear how, or what > it's checking. A "make check" in that directory fails. I looked in > admin/* for an explanation of what's supposed to be done in > test/manual/etags, but found nothing. > > Perhaps a README should be added to that directory to explain how to use > it? Just say "make" in that directory, it should finish with no errors.