From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22763: 25.1.50; Feature Request -- A faster method to obtain line number at position. Date: Thu, 20 May 2021 12:08:43 +0300 Message-ID: <834kexpyas.fsf@gnu.org> References: <83cztlq4wq.fsf@gnu.org> <87sg2hyie1.fsf@igel.home> <5vjNVOqvf9dNS_C5IpDYnu5V0nwdAkY0R5doUtx_Y4DgskVITLuZm09swlKj7PRY9g47nwei35U-4fRO_e5Tw7VrAK7RynVKHiY3kes_FOw=@protonmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39582"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 22763@debbugs.gnu.org To: Ben Levy Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 20 11:09:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljegj-000A3C-D9 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 11:09:53 +0200 Original-Received: from localhost ([::1]:54226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljegi-0004KR-3G for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 May 2021 05:09:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35746) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljefw-0004JZ-RD for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 05:09:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljefu-0006uX-Kq for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 05:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljefu-0004yp-FH for bug-gnu-emacs@gnu.org; Thu, 20 May 2021 05:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 May 2021 09:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22763 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 22763-submit@debbugs.gnu.org id=B22763.162150171919109 (code B ref 22763); Thu, 20 May 2021 09:09:02 +0000 Original-Received: (at 22763) by debbugs.gnu.org; 20 May 2021 09:08:39 +0000 Original-Received: from localhost ([127.0.0.1]:33087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljefX-0004y9-Bp for submit@debbugs.gnu.org; Thu, 20 May 2021 05:08:39 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljefW-0004xx-Hf for 22763@debbugs.gnu.org; Thu, 20 May 2021 05:08:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52778) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljefQ-0006fj-UB; Thu, 20 May 2021 05:08:33 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2937 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljefQ-0004eG-Fp; Thu, 20 May 2021 05:08:32 -0400 In-Reply-To: <5vjNVOqvf9dNS_C5IpDYnu5V0nwdAkY0R5doUtx_Y4DgskVITLuZm09swlKj7PRY9g47nwei35U-4fRO_e5Tw7VrAK7RynVKHiY3kes_FOw=@protonmail.com> (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206932 Archived-At: > Date: Thu, 20 May 2021 07:35:21 +0000 > From: Ben Levy via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > No, because 'start' is the byte position. > > Oh, I was confused, sorry. In that case, I think the issue I'm having > is that it still compares to BEGV even when absolute is non-nil. > I think it should compare to BEG instead. No, because POSITION should still be in the accessible portion of the buffer. The function only counts the lines since from BOB, but that doesn't imply POSITION can be outside BEGV..ZV. > Also this, and I think the comment has a typo ("n" should be "in"?). Yes, already fixed. Thanks.