unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: teika@gmx.com, 33847@debbugs.gnu.org, larsi@gnus.org, ulm@gentoo.org
Subject: bug#33847: 27.0.50; emacsclient does not find server socket
Date: Sun, 25 Jul 2021 10:27:43 +0300	[thread overview]
Message-ID: <834kciyhsg.fsf@gnu.org> (raw)
In-Reply-To: <5d2f6394-2fc0-e20a-9018-0ea59f399ba2@cs.ucla.edu> (message from Paul Eggert on Sat, 24 Jul 2021 16:31:21 -0700)

> Cc: larsi@gnus.org, teika@gmx.com, 33847@debbugs.gnu.org, ulm@gentoo.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 24 Jul 2021 16:31:21 -0700
> 
> From 4f8392f633cbd3b978c05b972983cfef82be4e7b Mon Sep 17 00:00:00 2001
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Sat, 24 Jul 2021 16:11:16 -0700
> Subject: [PATCH 4/4] Port recent Gnulib changes to MS-Windows
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> * nt/gnulib-cfg.mk (OMIT_GNULIB_MODULE_free-posix)
> (OMIT_GNULIB_MODULE_malloc-posix)
> (OMIT_GNULIB_MODULE_realloc-gnu)
> (OMIT_GNULIB_MODULE_realloc-posix):
> New macros, since we don’t want these modules on MS-Windows.
> * src/w32heap.c (heap_alloc, heap_realloc): New functions.
> (malloc_after_dump, realloc_after_dump, realloc_before_dump):
> Use them.

Thanks, this LGTM, but I have one minor request:

> +static void *
> +heap_alloc (size_t size)
> +{
> +  void *p = size <= PTRDIFF_MAX ? HeapAlloc (heap, 0, size | !size) : NULL;

Please add a comment here to explain the rationale for the
"size | !size" trick.

> +static void *
> +heap_realloc (void *ptr, size_t size)
> +{
> +  void *p = (size <= PTRDIFF_MAX
> +	     ? HeapReAlloc (heap, 0, ptr, size | !size)

Likewise here.

Btw, HeapAlloc does return a non-NULL pointer if SIZE is zero, so I'm
not sure the protection is needed.  But it cannot hurt.





  parent reply	other threads:[~2021-07-25  7:27 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-23  9:48 bug#33847: 27.0.50; emacsclient does not find server socket Ulrich Mueller
2018-12-23 16:20 ` Ulrich Mueller
2018-12-25 21:02 ` Paul Eggert
2018-12-25 23:29   ` Ulrich Mueller
2018-12-26  0:24     ` Paul Eggert
2018-12-26  2:27       ` Ulrich Mueller
2018-12-26  6:59         ` Paul Eggert
2018-12-26 15:14           ` Ulrich Mueller
2018-12-26 18:32             ` Paul Eggert
2018-12-28  6:37               ` Ulrich Mueller
2018-12-30  6:47                 ` Paul Eggert
2018-12-27  3:38       ` Richard Stallman
2018-12-27 16:42         ` Paul Eggert
2018-12-27 17:13           ` Paul Eggert
2018-12-28  6:19             ` Ulrich Mueller
2018-12-28  6:35               ` Paul Eggert
2018-12-28  6:51                 ` Ulrich Mueller
2018-12-30  6:44                   ` Paul Eggert
2019-01-20 17:59                     ` Ulrich Mueller
2019-02-10  8:37                       ` Ulrich Mueller
2019-02-10  9:48                         ` Eli Zaretskii
2020-08-19 11:05                           ` Lars Ingebrigtsen
2020-08-21 21:28                             ` Paul Eggert
2020-08-22  7:24                               ` Ulrich Mueller
2020-08-22  7:33                                 ` Andreas Schwab
2020-08-22  7:45                                   ` Ulrich Mueller
2020-08-22  8:00                                 ` Eli Zaretskii
2020-08-22 17:51                                 ` Paul Eggert
2020-08-22  7:59                               ` Eli Zaretskii
2020-08-22 17:55                                 ` Paul Eggert
2020-08-22 18:30                                   ` Eli Zaretskii
2020-08-22 21:20                                     ` Paul Eggert
2020-08-23  5:41                                       ` Eli Zaretskii
2021-07-22 13:08                                         ` Lars Ingebrigtsen
2021-07-22 16:45                                           ` Eli Zaretskii
2021-07-22 17:05                                             ` Lars Ingebrigtsen
2021-07-22 17:30                                               ` Eli Zaretskii
2021-07-23 11:31                                                 ` Lars Ingebrigtsen
2021-07-23 11:38                                                   ` Lars Ingebrigtsen
2021-07-23 23:58                                                     ` Paul Eggert
2021-07-24  6:23                                                       ` Eli Zaretskii
2021-07-24  7:48                                                         ` Paul Eggert
2021-07-24  8:25                                                           ` Eli Zaretskii
2021-07-24 23:31                                                             ` Paul Eggert
2021-07-25  6:32                                                               ` Eli Zaretskii
2021-07-25 16:22                                                                 ` Paul Eggert
     [not found]                                                                 ` <a0688fd6-9e73-73d8-6138-3280981abcb5@cs.ucla.edu>
2021-07-25 16:34                                                                   ` Eli Zaretskii
2021-10-04  6:45                                                                   ` Paul Eggert
2021-07-25  7:27                                                               ` Eli Zaretskii [this message]
2021-07-24 10:11                                                       ` Lars Ingebrigtsen
2021-07-24 19:37                                                         ` Paul Eggert
2021-07-23 11:58                                                   ` Eli Zaretskii
2021-07-22 18:30                                             ` Ulrich Mueller
2019-04-27  1:41 ` Teika Kazura
2019-04-27  7:56   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834kciyhsg.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=33847@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=larsi@gnus.org \
    --cc=teika@gmx.com \
    --cc=ulm@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).