unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 51094@debbugs.gnu.org
Subject: bug#51094: Check if run-with{-idle, }-timer needs to create a timer
Date: Fri, 08 Oct 2021 14:08:03 +0300	[thread overview]
Message-ID: <834k9rzsdo.fsf@gnu.org> (raw)
In-Reply-To: <87a6jj97u1.fsf@posteo.net> (message from Philip Kaludercic on Fri, 08 Oct 2021 09:36:22 +0000)

> From: Philip Kaludercic <philipk@posteo.net>
> Date: Fri, 08 Oct 2021 09:36:22 +0000
> 
> I have seen a few packages use run-with-timer or run-with-idle-timer,
> where the SECS parameter is configurable with a user option. When this
> timer doesn't repeat itself and it makes sense to set SECS to 0 when you
> want something to run immediately, I don't think it makes sense to
> create a timer object.
> 
> The following patch would remove this overhead, and calls the function
> immediately if it makes sense.

I'm not sure we should care, but in any case, what you do there
requires a comment explaining the rationale.

Thanks.





      parent reply	other threads:[~2021-10-08 11:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-08  9:36 bug#51094: Check if run-with{-idle,}-timer needs to create a timer Philip Kaludercic
2021-10-08 10:46 ` bug#51094: Check if run-with{-idle, }-timer " Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-08 10:53   ` Lars Ingebrigtsen
2021-10-08 11:14     ` Lars Ingebrigtsen
2021-10-08 11:33       ` Philip Kaludercic
2021-10-08 12:29         ` Lars Ingebrigtsen
2021-10-08 11:03   ` Philip Kaludercic
2021-10-08 11:29     ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-08 11:13   ` Eli Zaretskii
2021-10-08 11:08 ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834k9rzsdo.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=51094@debbugs.gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).