From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51556: 29.0.50; Poor contrast of Customize SVG icons with dark backgrounds Date: Tue, 02 Nov 2021 20:53:11 +0200 Message-ID: <834k8ujso8.fsf@gnu.org> References: <87v91b92v6.fsf@gmail.com> <83fssflmcg.fsf@gnu.org> <68034911-bc12-0c9e-cabb-c870628fd80c@gmail.com> <83a6imlo23.fsf@gnu.org> <83tuguk3h2.fsf@gnu.org> <83k0hqjywm.fsf@gnu.org> <83ee7yjxb1.fsf@gnu.org> <83a6imjv2o.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28141"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 02 19:55:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mhywJ-0007At-KV for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 19:55:19 +0100 Original-Received: from localhost ([::1]:47332 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mhywH-0002Ir-Gp for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 14:55:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyv5-000052-1e for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:54:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54765) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mhyv4-0008LO-Oo for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mhyv4-00049Y-Ll for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 14:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Nov 2021 18:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51556 X-GNU-PR-Package: emacs Original-Received: via spool by 51556-submit@debbugs.gnu.org id=B51556.163587920215886 (code B ref 51556); Tue, 02 Nov 2021 18:54:02 +0000 Original-Received: (at 51556) by debbugs.gnu.org; 2 Nov 2021 18:53:22 +0000 Original-Received: from localhost ([127.0.0.1]:38073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyuP-000489-TY for submit@debbugs.gnu.org; Tue, 02 Nov 2021 14:53:22 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mhyuO-00047u-52 for 51556@debbugs.gnu.org; Tue, 02 Nov 2021 14:53:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51450) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyuI-0008Fi-RE; Tue, 02 Nov 2021 14:53:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aFfJyfyuxJBlVNL47BN/Y6ClxvRwdX4cvtwBUyA5BfM=; b=JDlAKScx2Mx9 nqJBEcb3SQO9X2rzzivsoqwi8GuEGsmeE5otYAuQ7cKda97Fq2+ufnHY6e0bjz5gmuindDFAhhpU9 HSKcB5V+6ICcNeG0QAimFmwNWivcqATJ69ikUU/8hKdmMoX+6QtIOox/vTNAeRFrkBJ69CY1VvjnI C3OGALZECUbWCcvjtKq7vT7Qa6wJPKzAWvLEmGip5eJwcknPcS40H45fgCx8qXr4JAXFj1j9mXvK0 zAwnmUUIXJT3Crpnrd1rq2QCAjzIckpcYoZH1Inc0D6OrxtcTzSSC6LmVMejm7NliDhErOYItlcjt HeSXGZIWmU58wT9x6v7Ekw==; Original-Received: from [87.69.77.57] (port=3789 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mhyuI-0000L5-At; Tue, 02 Nov 2021 14:53:14 -0400 In-Reply-To: (message from Stefan Kangas on Tue, 2 Nov 2021 11:43:08 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218827 Archived-At: > From: Stefan Kangas > Date: Tue, 2 Nov 2021 11:43:08 -0700 > Cc: jporterbugs@gmail.com, 51556@debbugs.gnu.org, kevin.legouguec@gmail.com > > Eli Zaretskii writes: > > > If the solution you propose only works for SVG that specify no > > foreground, then it won't be able to solve all of the situations where > > a different theme makes an icon barely visible or unpleasant to the > > eye. > > It is certainly the correct solution for all the sets of scalable icons > that I have reviewed. Which SVG icons do you have in mind? Could you > point me to them? Try splash.svg, as a trivial example (and forget that it's too large for an icon, this is just an example). > For the icons I know of, the best solution if you need to change the > color of this or that icon, is to either change the active defface to > use the correct color, or to introduce a new defface. This is, not by > accident, the chosen solution also for icons on the web. We have a disconnect here, because I don't follow. Are you talking only about SVG that use only the gray color for its lines? > > Which is why I think a better solution would be to allow themes > > to specify different icons where necessary. > > Color themes should not *need* to provide their own icons when all they > want is to change the color of an icon. I said "should allow", and you say "need". We are mis-communicating. And that's in addition to the color business, where we also have some sort of disconnect. > Furthermore, the patch I have already posted here is sufficient for the > purposes of this bug report. I suggest we install it. On master? I don't object.