From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52053: 29.0.50; Nonsensical button "C-x C-f" in scratch buffer Date: Thu, 25 Nov 2021 16:16:18 +0200 Message-ID: <834k805nil.fsf@gnu.org> References: <87czmr5gr7.fsf.ref@yahoo.com> <87czmr5gr7.fsf@yahoo.com> <612d659daa29af13c2e5@heytings.org> <83y25c5wn0.fsf@gnu.org> <612d659daabc268505c4@heytings.org> <83pmqo5vmp.fsf@gnu.org> <612d659daad03d6bc73d@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24979"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 25 15:17:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqFYl-0006G4-J8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 15:17:11 +0100 Original-Received: from localhost ([::1]:52548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mqFYk-0003MM-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 Nov 2021 09:17:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:52700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqFYc-0003JJ-VY for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 09:17:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44711) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mqFYc-0006cp-Ma for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 09:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mqFYc-0005IE-IP for bug-gnu-emacs@gnu.org; Thu, 25 Nov 2021 09:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Nov 2021 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52053 X-GNU-PR-Package: emacs Original-Received: via spool by 52053-submit@debbugs.gnu.org id=B52053.163784978420291 (code B ref 52053); Thu, 25 Nov 2021 14:17:02 +0000 Original-Received: (at 52053) by debbugs.gnu.org; 25 Nov 2021 14:16:24 +0000 Original-Received: from localhost ([127.0.0.1]:56257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqFY0-0005HD-CC for submit@debbugs.gnu.org; Thu, 25 Nov 2021 09:16:24 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mqFXy-0005Gz-Hv for 52053@debbugs.gnu.org; Thu, 25 Nov 2021 09:16:23 -0500 Original-Received: from [2001:470:142:3::e] (port=43278 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqFXt-00067b-AM; Thu, 25 Nov 2021 09:16:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CJ/JRlANdTUUeS0KIcOMAGN9nW/khvVkkX9fP9E+McU=; b=fmbrykTNGb6b wsh/tCMu4qjcFscCTFQjePfFfnWSfAdH+08eqWtBzsiqr1OBlJtY6sCHkaZjmCS5R6gzApv26lmQm YkQlymwuSvT64yOc9Nli/ffNvpaElrQu5OtFUWlm7vlOLI46q916fEvlNdhYRV2qcRbCGdpVTceGr Fxd4k7fohBBTsV4t6vr1SY9OHXVf6cDPeCUjRsNtY1Kec3K5KD2LrDJfnlbIHuZicS8hy5dhLh0zN AmkJiPOITXmgpgJlQ9hJVyWQNgGY9RwiIsOduUCV0+dFwqA0C4sw8+XRyzmYm63Kfb85fAul9RBEq UTVTKPluRvabSDppNc5P4g==; Original-Received: from [87.69.77.57] (port=2031 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mqFXs-0002By-UT; Thu, 25 Nov 2021 09:16:17 -0500 In-Reply-To: <612d659daad03d6bc73d@heytings.org> (message from Gregory Heytings on Thu, 25 Nov 2021 13:41:50 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220835 Archived-At: > Date: Thu, 25 Nov 2021 13:41:50 +0000 > From: Gregory Heytings > cc: luangruo@yahoo.com, larsi@gnus.org, 52053@debbugs.gnu.org > > AFAICS, the options are: > > 1. Detect inside substitute-command-keys whether the string is for a > *Help* buffer. That's what the patch does, it's the simplest solution > from the point of view of those who call s-c-k. > > 2. Add an optional parameter to s-c-k to indicate whether the string is > for a non-*Help* buffer. That's a reasonable alternative, but there are > ~450 calls to s-c-k in the trunk, each would have to be checked. > > 3. Add a variable and let-bind it around the calls to s-c-k to indicate > when the string is for a non-*Help* buffer. > > 4. Let-bind help-link-key-to-documentation to nil around the calls to > s-c-k to indicate that the calls to help-mode--add-function-link should be > skipped. ISTM that this is not generic enough, if in six months we had > another similar feature it would be necessary to let-bind two variables > around calls for non-*Help* buffers, and so forth. I think the best solution is to change the default value of help-link-key-to-documentation to be nil, and then bind it to non-nil in Help commands. I'm not sure I understand what additional feature you have in mind and how such an additional feature could be related to this discussion. So please elaborate on that part.