From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54633: [PATCH] * configure.ac: Fix --without-gif for W32, NS, Haiku, and PGTK. Date: Wed, 30 Mar 2022 16:27:02 +0300 Message-ID: <834k3f8tax.fsf@gnu.org> References: <83bkxn8wpp.fsf@gnu.org> <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15748"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 54633@debbugs.gnu.org To: Randy Taylor , Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Mar 30 15:41:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZYa8-0003x3-Np for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 15:41:52 +0200 Original-Received: from localhost ([::1]:46674 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZYa7-0001nr-3C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 30 Mar 2022 09:41:51 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:58274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZYMk-0004HI-Hk for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:28:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40905) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZYMj-0006he-Sz for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nZYMj-0001BM-Q9 for bug-gnu-emacs@gnu.org; Wed, 30 Mar 2022 09:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 30 Mar 2022 13:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54633 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54633-submit@debbugs.gnu.org id=B54633.16486468254178 (code B ref 54633); Wed, 30 Mar 2022 13:28:01 +0000 Original-Received: (at 54633) by debbugs.gnu.org; 30 Mar 2022 13:27:05 +0000 Original-Received: from localhost ([127.0.0.1]:34802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYLo-00015J-VY for submit@debbugs.gnu.org; Wed, 30 Mar 2022 09:27:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:42134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nZYLo-00014S-3N for 54633@debbugs.gnu.org; Wed, 30 Mar 2022 09:27:04 -0400 Original-Received: from [2001:470:142:3::e] (port=34154 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZYLi-0006PH-KQ; Wed, 30 Mar 2022 09:26:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=24oWlmRSl6RWpJE9FZry3t7hBT4X977snE8oN+sKE7I=; b=OfP5uL+ijdt8 TVgljBmzYhmPBByRTvD7JmNZdWHx243lSpoK1+wZvfE3z9oLSQSEYjkfIqFQPw1k0fZpqFRypoi89 Kqvm3MXQ2WjvvMrEGgH4N4khyVG/s7TId8jTobybgOGC30I1IC0qlYo0nA3UgqmWOHbCVQWON/MH6 HhPK+68f1KPvltKEV5AjWwnuT8T4KHAm0V0Hf/NxZFJCmRKSZ0nADxFXJKwdR9uOr7vIwdPRq1e7u TdtsGk9Cl1PfwMPhziN27XyhcJeQOU6JZ8r6Ux1o47p+JbgXIcSxdY2EDtIUs3FygS74dUAydfE4E q1pxY2TI4Eoc4JPyCWlw/g==; Original-Received: from [87.69.77.57] (port=4771 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZYLe-0003YS-Va; Wed, 30 Mar 2022 09:26:58 -0400 In-Reply-To: <9EqAhFUloeB4kQNtbW9VlWwN8Z3sNW2ymLkuwBA1XV5j19ttoHI_X78nrUFrz_2uqvJAu2DuGDJk0SMb2XeNUZVQgsp7EmJpzWoaWemfDVg=@rjt.dev> (message from Randy Taylor on Wed, 30 Mar 2022 12:42:54 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229109 Archived-At: > Date: Wed, 30 Mar 2022 12:42:54 +0000 > From: Randy Taylor > Cc: 54633@debbugs.gnu.org > > When I build Emacs I specify "--without-gif". > > When using PGTK: > - With the original code and specifying "--without-gif", here is what configure gives me: Does Emacs use a gif library? yes -lgif > - With the patch and specifying "--without-gif", I get this (as expected): Does Emacs use a gif library? no > - With the patch, if I remove "--without-gif" or specify "--with-gif=yes", I get this (as expected): Does Emacs use a gif library? yes -lgif > > When using X11: > - With the original code and specifying "--without-gif", here is what configure gives me (as expected): Does Emacs use a gif library? no > - With the original code and removing "--without-gif" or specifying "--with-gif="yes", here is what configure gives me (as expected): Does Emacs use a gif library? yes -lgif > > The check in the code for "--without-gif" only applies to X11, but not the other systems. > This patch fixes it to apply for all the systems in that check, in the same fashion as the SVG check (see line 2660 in configure.ac). Thanks. But your patch touched more than just the PGTK build. For w32, for example, I see no reason to make any changes; do you? Likewise for NS. Po Lu, do you agree that only PGTK needs a fix? If co, can you suggest a fix for PGTK only?