From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#55329: [PATCH] Choose latex environment for table.el export Date: Mon, 09 May 2022 14:25:35 +0300 Message-ID: <834k1zuevk.fsf@gnu.org> References: <87ee13wi72.fsf@laptop.lockywolf.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15343"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 55329@debbugs.gnu.org To: Vladimir Nikishkin Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 09 13:37:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1no1hE-0003p1-Q6 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 13:37:00 +0200 Original-Received: from localhost ([::1]:52790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1no1hD-0000vx-AS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 09 May 2022 07:36:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no1Wj-00081i-CG for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:26:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34275) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1no1Wb-0004JT-Nr for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:26:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1no1Wb-0002DY-Hr for bug-gnu-emacs@gnu.org; Mon, 09 May 2022 07:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 May 2022 11:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55329 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55329-submit@debbugs.gnu.org id=B55329.16520955478500 (code B ref 55329); Mon, 09 May 2022 11:26:01 +0000 Original-Received: (at 55329) by debbugs.gnu.org; 9 May 2022 11:25:47 +0000 Original-Received: from localhost ([127.0.0.1]:56405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1WM-0002D2-OQ for submit@debbugs.gnu.org; Mon, 09 May 2022 07:25:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:46536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1no1WK-0002Cm-WE for 55329@debbugs.gnu.org; Mon, 09 May 2022 07:25:45 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:48934) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no1WF-00049R-O5; Mon, 09 May 2022 07:25:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z8NnsPW+/CydznC6Mz1Ut7mLozPezD7QRjSiLjTwIww=; b=o4Wf7QRHBVml 0QY+OEgyFR2hhtjxNq3tMERUETZlbIUvBzgSYT91EVvb9TK5xLev7rMry7uTgr6ufdap7LTtzVJdK nEH4CeBLaTiLkVNVvi4kBZ1O6XBFn9COofqKShpDj4GMDNaM0Dqui6ft7zUpQzq2XCSjzuIxoYyBT UEOEnTSjOW+Lbd/hjmuA4gCFSBMXalyv/SEa3m1FYgzUU6jXRVjM0bBth5AqLKiRL7h+AhC05FuzZ YhaBYK//5N2/1RS/7kcUcYaMHLnLv95XzAkrpFd76Kmhm224s4B/8lR8xIRjXkBgtNhOilmCdoo0W i0+ewsSIHs/wxCysQbhTlg==; Original-Received: from [87.69.77.57] (port=4003 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1no1WF-0007kV-7o; Mon, 09 May 2022 07:25:39 -0400 In-Reply-To: <87ee13wi72.fsf@laptop.lockywolf.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231726 Archived-At: > From: Vladimir Nikishkin > Date: Mon, 09 May 2022 10:30:57 +0800 > > The patch creates 1 new customize variable: > 1. table-latex-environment > > And changes the following 2 functions: > 1. table--generate-source-epilogue > 2. table--generate-source-prologue Thanks. A couple of minor nits: > +(defcustom table-latex-environment "tabular" > + "Which tabular-compatible environment to use when generating latex. > +tabular and longtable are known to work." I'm not sure I understand the purpose of the last sentence, nor what it adds to the doc string. Also, perhaps we should prefer symbol values, not string values here? Symbols are easier to compare and harder to make mistakes.