bug#55906: [PATCH] Make directory line in find-dired clickable

bug#55906: [PATCH] Make directory line in find-dired clickable

[Visuwesh]

[-- Attachment #1: Type: text/plain, Size: 633 bytes --]

Tags: patch

Tags: patch

Attached patch makes find-dired respect the
`dired-make-directory-clickable' user option.



In GNU Emacs 29.0.50 (build 13, x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2022-06-10 built on astatine
Repository revision: 53139e53b75aa37cc808c1c8b3e3be367ae09fb3
Repository branch: add-mksh-imenu
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Debian GNU/Linux 11 (bullseye)

Configured using:
 'configure --with-modules --without-cairo --with-sound=alsa
 --with-x-toolkit=lucid --with-json --without-xaw3d --without-gconf
 --without-systemd --with-x'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-find-dired.el-find-dired-Make-directory-clickab.patch --]
[-- Type: text/patch, Size: 818 bytes --]

From c8d951830f60a1c9f137e85da9a1ed5072dfc13e Mon Sep 17 00:00:00 2001
From: Visuwesh <visuweshm@gmail.com>
Date: Sat, 11 Jun 2022 19:00:27 +0530
Subject: [PATCH] * lisp/find-dired.el (find-dired): Make directory clickable.

---
 lisp/find-dired.el | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lisp/find-dired.el b/lisp/find-dired.el
index c04545e44e..8c1e684b7e 100644
--- a/lisp/find-dired.el
+++ b/lisp/find-dired.el
@@ -241,6 +241,8 @@ find-dired
     ;; Subdir headlerline must come first because the first marker in
     ;; subdir-alist points there.
     (insert "  " dir ":\n")
+    (when dired-make-directory-clickable
+      (dired--make-directory-clickable))
     ;; Make second line a ``find'' line in analogy to the ``total'' or
     ;; ``wildcard'' line.
     (let ((point (point)))
-- 
2.35.1

bug#55906: [PATCH] Make directory line in find-dired clickable

[Eli Zaretskii]

> From: Visuwesh <visuweshm@gmail.com>
> Date: Sat, 11 Jun 2022 19:01:47 +0530
> 
> diff --git a/lisp/find-dired.el b/lisp/find-dired.el
> index c04545e44e..8c1e684b7e 100644
> --- a/lisp/find-dired.el
> +++ b/lisp/find-dired.el
> @@ -241,6 +241,8 @@ find-dired
>      ;; Subdir headlerline must come first because the first marker in
>      ;; subdir-alist points there.
>      (insert "  " dir ":\n")
> +    (when dired-make-directory-clickable
> +      (dired--make-directory-clickable))

Won't we need to make that function be public for this, and rename it
to dired-make-directory-clickable?

Thanks.

bug#55906: [PATCH] Make directory line in find-dired clickable

[Visuwesh]

[சனி ஜூன் 11, 2022] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm@gmail.com>
>> Date: Sat, 11 Jun 2022 19:01:47 +0530
>> 
>> diff --git a/lisp/find-dired.el b/lisp/find-dired.el
>> index c04545e44e..8c1e684b7e 100644
>> --- a/lisp/find-dired.el
>> +++ b/lisp/find-dired.el
>> @@ -241,6 +241,8 @@ find-dired
>>      ;; Subdir headlerline must come first because the first marker in
>>      ;; subdir-alist points there.
>>      (insert "  " dir ":\n")
>> +    (when dired-make-directory-clickable
>> +      (dired--make-directory-clickable))
>
> Won't we need to make that function be public for this, and rename it
> to dired-make-directory-clickable?
>
> Thanks.

AFAICT, dired--make-directory-clickable is specific to dired buffers,
and since find-dired is "dired-compatible" I don't see a need to make
the function public.

bug#55906: [PATCH] Make directory line in find-dired clickable

[Lars Ingebrigtsen]

Visuwesh <visuweshm@gmail.com> writes:

> Attached patch makes find-dired respect the
> `dired-make-directory-clickable' user option.

Thanks; pushed to Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no