From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56561: 29.0.50; Infloop in try_window Date: Sat, 16 Jul 2022 08:50:25 +0300 Message-ID: <834jzhsj1a.fsf@gnu.org> References: <874jzjwmhn.fsf@md5i.com> <83v8rzsdd1.fsf@gnu.org> <878rovxqjo.fsf@md5i.com> <83sfn2sy19.fsf@gnu.org> <83lesusl4w.fsf@gnu.org> <87lesumqgf.fsf@yahoo.com> <83ilnysbc5.fsf@gnu.org> <83fsj2s8fg.fsf@gnu.org> <83cze6s7xt.fsf@gnu.org> <83bktqs724.fsf@gnu.org> <878rotlpck.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11480"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mwd@md5i.com, 56561@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 16 07:51:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCahq-0002ok-Fm for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 07:51:10 +0200 Original-Received: from localhost ([::1]:52622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oCahp-0007tk-Jw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Jul 2022 01:51:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCahi-0007tL-KP for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 01:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45011) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oCahi-0000ez-9c for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 01:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oCahi-0007KF-48 for bug-gnu-emacs@gnu.org; Sat, 16 Jul 2022 01:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2022 05:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56561 X-GNU-PR-Package: emacs Original-Received: via spool by 56561-submit@debbugs.gnu.org id=B56561.165795063428125 (code B ref 56561); Sat, 16 Jul 2022 05:51:02 +0000 Original-Received: (at 56561) by debbugs.gnu.org; 16 Jul 2022 05:50:34 +0000 Original-Received: from localhost ([127.0.0.1]:42769 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCahG-0007JY-4O for submit@debbugs.gnu.org; Sat, 16 Jul 2022 01:50:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oCahE-0007JF-RQ for 56561@debbugs.gnu.org; Sat, 16 Jul 2022 01:50:33 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:51156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCah9-0000bw-Hz; Sat, 16 Jul 2022 01:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jK/lrhUpFk0abECvBHnwh7tca0cGshYZc1L6RItdv2w=; b=fbewjQFLghf+ pgEhqdxBrij+62wnuR+mJRP4OGm3ebkqBCaMMN5MXG3b3G6CPoBv3A1iW46QmcYzSR6oOD3dT2RpV SjZ0XMJe/25kREIG80E3KRQLXu4H1UXc6RoprZR8B0Xq5WzR9JPAZeW+M/4Lqupl7vAxz8NnSEosr fhdY2izrcTiouatTXXFPnwSLVxxK3WVnM6foVHn2o/4Er8Xn6XLk6z7bEjecpiclCtvRWojIUV13R OhniDHIU2swQjKxNp0op+7vDEnbxXpq/UcQBGEyqTlqKi8uFbBkRhmiWrQ99zeMIfSmJKT1gmm1R5 JvLAHV7jwVAkJErujzHE2A==; Original-Received: from [87.69.77.57] (port=4351 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oCah9-0007tE-2H; Sat, 16 Jul 2022 01:50:27 -0400 In-Reply-To: <878rotlpck.fsf@yahoo.com> (message from Po Lu on Sat, 16 Jul 2022 11:15:55 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:237141 Archived-At: > From: Po Lu > Cc: mwd@md5i.com, 56561@debbugs.gnu.org > Date: Sat, 16 Jul 2022 11:15:55 +0800 > > Eli Zaretskii writes: > > > No, that's wrong: we call update_single_window there, and that > > requires a window with a desired matrix set up correctly. So yes, the > > call to try_window is still needed. > > Indeed. So would you prefer an assertion in try_window Not sure which assertion you had in mind. It cannot be easily done inside try_window, because that function is called from many places unrelated to tooltips. What I had in mind is an assertion in x-show-tip that the glyph matrix produced by try_window includes all of the tooltip text, i.e. that there's a glyph row there whose ends_at_zv_p flag is set. This is an indication that all of the text was processed and will appear in the tooltip. Note that in the case in point this is precisely what's happened: the entire text of the tip was processed and produced its glyphs, and the problem happened while try_window was producing empty glyph rows beyond ZV. > or a call to adjust_frame_glyphs if it fails? No, because as I explained in my message, I don't think this should be needed. If the above assertion ever triggers, we will see what kind of situation causes it, and can then discuss solutions.