From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60841: 30.0.50; kill-ring-save pauses despite region being highlighted Date: Sat, 21 Jan 2023 10:08:23 +0200 Message-ID: <834jskmhs8.fsf@gnu.org> References: <87h6wrs71h.fsf@gmail.com> <83zgai4peg.fsf@gnu.org> <5583fd58387746ce7ddc@heytings.org> <87cz7dbns0.fsf@gmail.com> <4c2c6cf44ad37e405b06@heytings.org> <878ri0g6ob.fsf@gmail.com> <83pmbc0yxo.fsf@gnu.org> <87y1pzo5dp.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26492"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60841@debbugs.gnu.org To: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 21 09:09:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pJ8w9-0006l1-KN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Jan 2023 09:09:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJ8vv-00057x-K0; Sat, 21 Jan 2023 03:09:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8vu-00057o-Pu for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 03:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJ8vu-00031b-Ca for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 03:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pJ8vu-0002If-55 for bug-gnu-emacs@gnu.org; Sat, 21 Jan 2023 03:09:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Jan 2023 08:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60841 X-GNU-PR-Package: emacs Original-Received: via spool by 60841-submit@debbugs.gnu.org id=B60841.16742885118793 (code B ref 60841); Sat, 21 Jan 2023 08:09:02 +0000 Original-Received: (at 60841) by debbugs.gnu.org; 21 Jan 2023 08:08:31 +0000 Original-Received: from localhost ([127.0.0.1]:47964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8vP-0002Hk-5u for submit@debbugs.gnu.org; Sat, 21 Jan 2023 03:08:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56420) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJ8vN-0002HX-HA for 60841@debbugs.gnu.org; Sat, 21 Jan 2023 03:08:29 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8vH-0001OH-RP; Sat, 21 Jan 2023 03:08:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lLQgFlkTK0Uvlw1btZLkTPS/OX2Dz4LLCulg1qSIYOM=; b=nqgziwTqQH2mNxRQMR/r ji8Rpkyrf+mZK/cGjrBIc1SC/cfWWo+S+R2khIaXlrajWxh8yPMDkt2px6Wd5Qvlow5lG5gu5GOrz pFMpDhuM4M1iU4dhxJOGreyiHLCfeRE/DgyLhLyRDf8gcsXzbdzKqcoBzReZ/zJjAqIghYceLrUaM Xf4B7piRecvIr3xVhjbgv9dlXzlQp1thHMgw2bKxVoJXrwFR6/oTENewX3zY/DUmZgGiYdfqhjFRF SfylgqW3E6sNbyrvplYKPhX6mrUOxrwkBpjc8+UF558UOeEw/+QKwd8AbT1f6ouPxp4/qTDLljCLk Yi6Oyoqyvi3pAQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJ8vF-0004Zp-3U; Sat, 21 Jan 2023 03:08:22 -0500 In-Reply-To: <87y1pzo5dp.fsf@gmail.com> (message from =?UTF-8?Q?K=C3=A9vin?= Le Gouguec on Wed, 18 Jan 2023 23:16:34 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253835 Archived-At: > From: Kévin Le Gouguec > Cc: gregory@heytings.org, 60841@debbugs.gnu.org > Date: Wed, 18 Jan 2023 23:16:34 +0100 > > > * :extend nil for both: they display differently (region will not be > > extended, default will be), > > * :extend t for both: they display the same, > > * default has nil, region has t: they display the same, > > * default has t, region has nil: they display differently. The default face is always extended, so it should be treated as implicitly having the :extend attribute set. I think face-differs-from-default-p should be fixed to either ignore the :extend attribute like it ignores :inherit (since it could be argued that :extend doesn't really control how the face affects characters on display), or it should treat the default face as having the :extend attribute with the value t. Can you see if any of these changes cause any trouble in our own use of face-differs-from-default-p? AFAICT, it will actually fix a subtle problem in diff-mode.el: if diff-changed face doesn't define non-default colors, it will be still taken as different from 'default', which I think is contrary to what diff-mode expects. If we make the above change in face-differs-from-default-p, would using it for the purpose of this issue fix the problem? > (Hm, and against my better judgement I went ahead and compared > gui_supports_face_attributes_p vs tty_supports_face_attributes_p, and I > see that they handle :extend differently and *mashes C-c C-c with > forehead before fingers can type another wall of text*) TTY frames always extend the color, that's the reason for the difference. But does this affect my proposal above?