unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Phil Sainty <psainty@orcon.net.nz>
Cc: diredwolf1@gmail.com, 57080@debbugs.gnu.org
Subject: bug#57080: 29.0.60; [PATCH] Updates to mode line construct documentation (was: The %m modeline construct does not work for emacs-lisp-mode)
Date: Sat, 18 Mar 2023 09:46:54 +0200	[thread overview]
Message-ID: <834jqicxht.fsf@gnu.org> (raw)
In-Reply-To: <87bdaf86c1edac42a5c004c14364608b@webmail.orcon.net.nz> (message from Phil Sainty on Sat, 18 Mar 2023 20:22:24 +1300)

> Date: Sat, 18 Mar 2023 20:22:24 +1300
> From: Phil Sainty <psainty@orcon.net.nz>
> Cc: diredwolf1@gmail.com, 57080@debbugs.gnu.org
> 
> Does anyone object to me merging branch 
> fix/bug-57080-mode-line-format-docs
> ( https://lists.gnu.org/archive/html/emacs-diffs/2023-03/msg00453.html )
> to the emacs-29 branch?

It goes too far, IMO, see below.

> It addresses the issue from this bug along with several related things
> that I found in the process of looking at that.
> 
> * The %m documentation was not entirely accurate (as discussed here).

But you moved it from its place near the end of the node (as
appropriate for obsolete features) to the mainline.  Why not leave it
where it was, and just add the explanation why its usage is not
advised?

> * The %M documentation was also not up to date.
> * The %t construct was obsolete but still documented.

So let's move %t to where %m is.

> * The %o and %q constructs were lacking documentation.

In the manual? I don't see them being added there.

> * The `mode-line-format' docstring for all of the constructs was
>    not as easy to read as it could have been.

I would leave this part alone on emacs-29, and only install the
reformatting of the doc string on master.

> The final reformatting of the `mode-line-format' docstring sorts the
> constructs by letter (which makes everything easier to find); eliminates
> multiple constructs being crammed into single lines (which also makes
> everything easier to find); and rephrases some things for (IMHO) easier
> readability and comprehension.

It also makes the text taller, thus requiring a larger Help window.
Is it still reasonably readable in "emacs -Q"?

Anyway, I think this part is for master.

> I untabified the indentation, as that didn't render correctly with a
> tab-width of anything other than 8, which might be a problem for other
> docstrings as well.  Should help-mode set tab-width to 8 ??

tab-width is a user variable, so no Lisp program should set it, IMO.

Bottom line:

  . I'm okay with manual changes, modulo the movement of %m -- it
    should stay where it was.
  . I'm okay with adding %t to the manual (in the "obsolete" part).
  . I'm okay with removing %t from the doc string.
  . I'm okay with fixing the doc string of global-mode-string.
  . All the rest is okay for master.

Thanks.





  parent reply	other threads:[~2023-03-18  7:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-09 16:06 bug#57080: 28.1; The %m modeline construct does not work for emacs-lisp-mode diredwolf
2022-08-09 16:45 ` Eli Zaretskii
     [not found]   ` <B27E1FE6-E7D2-4551-877B-9B1BC005AE56@gmail.com>
2022-08-09 17:06     ` Eli Zaretskii
2022-08-10  0:23       ` Phil Sainty
2022-08-10  2:40         ` Eli Zaretskii
2022-08-10 12:49           ` Phil Sainty
     [not found]             ` <87bdaf86c1edac42a5c004c14364608b@webmail.orcon.net.nz>
2023-03-18  7:30               ` bug#57080: 29.0.60; [PATCH] Updates to mode line construct documentation (was: The %m modeline construct does not work for emacs-lisp-mode) Phil Sainty
2023-03-18  7:46               ` Eli Zaretskii [this message]
2023-03-18  8:38                 ` bug#57080: 29.0.60; [PATCH] Updates to mode line construct documentation Phil Sainty
2023-03-18  8:54                   ` Eli Zaretskii
2023-03-18  9:25                     ` Phil Sainty
2023-03-26 11:43                     ` Phil Sainty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834jqicxht.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=57080@debbugs.gnu.org \
    --cc=diredwolf1@gmail.com \
    --cc=psainty@orcon.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).