From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Mon, 15 May 2023 21:37:59 +0300 Message-ID: <834jod1lvc.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27393"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63469@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 15 20:39:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyd6L-0006x7-0T for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 May 2023 20:39:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyd68-0007Yc-Bv; Mon, 15 May 2023 14:39:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyd66-0007YG-UP for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 14:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyd66-0004o8-J2 for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 14:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyd66-0002UF-Fy for bug-gnu-emacs@gnu.org; Mon, 15 May 2023 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.16841758849486 (code B ref 63469); Mon, 15 May 2023 18:39:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 15 May 2023 18:38:04 +0000 Original-Received: from localhost ([127.0.0.1]:44395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyd59-0002Sv-LB for submit@debbugs.gnu.org; Mon, 15 May 2023 14:38:03 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyd56-0002SP-5J for 63469@debbugs.gnu.org; Mon, 15 May 2023 14:38:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyd50-0004bl-R4; Mon, 15 May 2023 14:37:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KlHUm/p1iMx/x/z9743bxMrql/SPbSabhGEwZybosCY=; b=eNfNnMYJ1NzY xKELFXE/i/vqrh2oynmYnIYfhiHIgiY5hH4S8mg3FWV3ZvPv443tmQ6RgHuPk8Sh5sLcGbWBjKwvW y23lfnD1WTk5lufmJzTCqDnE1ejX+Bv6GLxZuwsSXy84bV0ju0aRSW1Qly6YIEP0kyk0zr2YA2hmW S+1q3YeHEZSP9DaGJLTd8fagGhYonB65r0QSvpBdMCw2itx0jyjUsVjGLnMAyyaQFo0MEoyrboxfC JrcFBDDRUhVq5bxEO55+tEtlvFGeUN6hctuyX0BkYPkvDtL31l6/P9n4TN+BQE7okoGEtGjjMX5bB lT5t/7KcxOtkleTXSiL0CA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyd4z-00012p-Gt; Mon, 15 May 2023 14:37:54 -0400 In-Reply-To: (message from Spencer Baugh on Mon, 15 May 2023 14:11:08 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261760 Archived-At: > From: Spencer Baugh > Date: Mon, 15 May 2023 14:11:08 -0400 > > The attached patch resolves this. There's also a slight tweak to the > text of the menu entry for "Compile" to make it clearer that "compile" > runs in CWD, where as "project-compile" runs on the current project. > Otherwise I think it would be slightly confusing. Thanks. > (defvar menu-bar-shell-commands-menu > (let ((menu (make-sparse-keymap "Shell Commands"))) > + (bindings--define-key menu [project-interactive-shell] > + '(menu-item "Run Shell Interactively In Project" project-shell > + :help "Run a subshell interactively, in the current project")) What does it mean to "run a shell in the current project"? A shell doesn't run in a project. Maybe you meant in the project's root directory? > + (bindings--define-key menu [project-compile] > + '(menu-item "Compile Project..." project-compile > + :help "Invoke compiler or Make for current project, view compilation errors")) This tool-tip text is too long. Maybe drop the "compilation" part. > + '(menu-item "Compile Current Directory..." compile > + :help "Invoke compiler or Make in current directory, view compilation errors")) What is a "current directory" when you are talking about Emacs? > + (list 'select-buffer-in-project > + 'menu-item > + "Select Buffer In Project..." > + 'project-switch-to-buffer > + :help "Prompt for a buffer name in the current project, and select that buffer in the current window") This tool-tip text is _way_ too long.