From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63690: 29.0.91; New vc commands missing on vc-menu Date: Wed, 24 May 2023 19:51:45 +0300 Message-ID: <834jo1oeou.fsf@gnu.org> References: <86cz2q404g.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20041"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63690@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 24 18:52:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1rib-000504-BZ for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 May 2023 18:52:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1riV-0007ce-7n; Wed, 24 May 2023 12:52:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1riU-0007cW-2v for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 12:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q1riT-0000Ej-RI for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 12:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q1riT-0007tv-N2 for bug-gnu-emacs@gnu.org; Wed, 24 May 2023 12:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 May 2023 16:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63690 X-GNU-PR-Package: emacs Original-Received: via spool by 63690-submit@debbugs.gnu.org id=B63690.168494708930170 (code B ref 63690); Wed, 24 May 2023 16:52:01 +0000 Original-Received: (at 63690) by debbugs.gnu.org; 24 May 2023 16:51:29 +0000 Original-Received: from localhost ([127.0.0.1]:44988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1rhw-0007qW-H3 for submit@debbugs.gnu.org; Wed, 24 May 2023 12:51:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q1rhs-0007pT-Ld for 63690@debbugs.gnu.org; Wed, 24 May 2023 12:51:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rhm-0008W0-PT; Wed, 24 May 2023 12:51:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z6Coi+2mtYv79hPKuzjpyCDkaFha1jy96+Ki7EEtjXg=; b=hW3L+IFaISSw Z4qwWJ5F8B6WP03VPS8cAdPrG6e81ecRFg6Y9YeJIwVZSbQEF1nYAHTgA2Y+nvv/gJWeTlfVWVG8U JMeXLHl2fNHzpYiuZTif+qsLHFlJZBOgzgNkQlywjeAzyfWbAPJw7jEgRZX4iPjob+uRNT439WKE0 ZPcB4nGRxl76BV82Uphsh3HthXLwlpZNsT5NIOGYXGNfhUdUty6tlK+mVGDl5x2wpIcSVMoZAvVdx 0XPx5bAIzKRo4OMHiH3AlKf/OyiO9Nbky2Oa4Z4MDaXE8ilu4BV7/jLl8337/8qYbBmEce9tcd9+Y 3K8Ul/rFYDbC1kMmgfPrlA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rhm-00069F-8p; Wed, 24 May 2023 12:51:18 -0400 In-Reply-To: <86cz2q404g.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 24 May 2023 19:16:23 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262310 Archived-At: > From: Juri Linkov > Date: Wed, 24 May 2023 19:16:23 +0300 > > etc/NEWS on emacs-29 contains: > > 'vc-print-branch-log' is bound to 'C-x v b l', and new commands are > 'vc-create-branch' ('C-x v b c') and 'vc-switch-branch' ('C-x v b s'). > > But new commands are not yet added to 'vc-menu-map'. > This patch for emacs-29 fixes this omission: Thanks. This is okay, but the help-echo text "needs work". > diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el > index 02c4a240c6a..402b918fc7d 100644 > --- a/lisp/vc/vc-hooks.el > +++ b/lisp/vc/vc-hooks.el > @@ -898,6 +927,15 @@ vc-menu-map > (bindings--define-key map [vc-create-tag] > '(menu-item "Create Tag" vc-create-tag > :help "Create version tag")) > + (bindings--define-key map [vc-print-branch-log] > + '(menu-item "Show Branch History" vc-print-branch-log > + :help "Show the change log for branch root")) What is "branch root"? > + (bindings--define-key map [vc-switch-branch] > + '(menu-item "Switch Branch" vc-switch-branch > + :help "Switch to the branch")) "the" branch? Also, AFAICT these commands are not described in the manual. If they are important enough to be on the menu bar, I think we should mention them in the manual as well, no?