From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 02 Jun 2023 15:58:05 +0300 Message-ID: <834jnqaun6.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <87h6rw8y82.fsf@gmail.com> <83353gipww.fsf@gnu.org> <87edmzto0l.fsf@gmail.com> <83ilcbgrxo.fsf@gnu.org> <87zg5nb3m3.fsf@gmail.com> <83bki3gpai.fsf@gnu.org> <87sfbfazfp.fsf@gmail.com> <837csrgioe.fsf@gnu.org> <87jzwqb7r3.fsf@gmail.com> <83ttvuf29m.fsf@gnu.org> <87a5xmaqul.fsf@gmail.com> <83r0qxg4q0.fsf@gnu.org> <875y88bhvr.fsf@gmail.com> <83ilc8eapd.fsf@gnu.org> <83edmvcpzl.fsf@gnu.org> <87wn0n9uol.fsf@gmail.com> <83a5xjcgev.fsf@gnu.org> <87sfbb9m4y.fsf@gmail.com> <87o7ly9t6b.fsf@gmail.com> <83edmuax13.fsf@gnu.org> <87fs7a9hl3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13873"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 02 14:58:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q54MC-0003Ny-TH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Jun 2023 14:58:17 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q54M0-0001Xv-4w; Fri, 02 Jun 2023 08:58:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q54Ly-0001XY-CX for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 08:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q54Ly-00069r-49 for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 08:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q54Lx-0000Jd-Vy for bug-gnu-emacs@gnu.org; Fri, 02 Jun 2023 08:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2023 12:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16857106611184 (code B ref 63731); Fri, 02 Jun 2023 12:58:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 2 Jun 2023 12:57:41 +0000 Original-Received: from localhost ([127.0.0.1]:39324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q54Ld-0000J1-40 for submit@debbugs.gnu.org; Fri, 02 Jun 2023 08:57:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q54La-0000Ij-92 for 63731@debbugs.gnu.org; Fri, 02 Jun 2023 08:57:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q54LU-0005z6-MX; Fri, 02 Jun 2023 08:57:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=P4iLppn/Y8f+TLJ1oCpcVIQKDYDcIvDzJcVyXtEa9Sg=; b=sBSaRLhznStFxzxoWJmO 81bBrQvOi8s9q6rzKfHkMXAW9PY6brrP3VSrprcvTTYVuPaaR7zdRpfoaXvzX6ZbjrW4UM4gwpWB+ zjec3JZqhmXnN0ML24asfjf7+tOICJ6b6jmwiUmW+j/EQDqyBFyHtMtHySTpvFiXwtAF1V8e3oCXe f+f0cxU0Y3mpH+DtcxSHZuSnrfk3nqpi+Pq5kQPdH+cC50nfqCDHj4N6gh5muY99/rc4Cq1OM8SRG EQqCd1AWfS/tGr6LYdY3udmEMpKwXU0HH7DtdkJ6mkPK3dB+gn6T2NZeyJtm5jrm1sET78UkPHTs5 zeMfc19VQ07jDQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q54LE-0001JK-1q; Fri, 02 Jun 2023 08:57:31 -0400 In-Reply-To: <87fs7a9hl3.fsf@gmail.com> (message from Robert Pluim on Fri, 02 Jun 2023 14:25:28 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262764 Archived-At: > From: Robert Pluim > Cc: 63731@debbugs.gnu.org, steven@stebalien.com > Date: Fri, 02 Jun 2023 14:25:28 +0200 > > Eli> Thanks, please install this on the emacs-29 branch. > > Closing. > Committed as 2f94f6de9d6 Thanks. > >> Proper VS-15 support is harder, I need to think about that some more. > > Eli> Can you describe here the current problems with VS-15? > > CHAR+VS-15 and CHAR+VS-16 correctly choose text and emoji > representation, but CHAR+VS-15 results in the text representation only > if CHAR is not an emoji. If it is an emoji, the font selected for it > will always be the emoji font. And an Emoji font, when presented with CHAR+VS-15 sequence doesn't produce a textual-representation glyph for CHAR? I'd expect it to. If Emoji fonts don't produce textual-representation glyphs in this case, I wonder how can this work at all. Because if we select some non-Emoji font, it will probably not know about VS-15, so we will be left with VS-15. Are we supposed to handle that ourselves, instead of relying on the font and the shaping engine? > Iʼve tried forcing font_range to use the font for the 'symbol' script > for EMOJI+VS-15, instead, but that resulted in composition > failing. That's what I'd expect: non-Emoji fonts don't know about VS-15. What does HarfBuzz's hb-view do with such sequences, when using Noto Color Emoji font?