From: Eli Zaretskii <eliz@gnu.org>
To: jean@tbm.email, Theodor Thornhill <theo@thornhill.no>
Cc: casouri@gmail.com, 65113@debbugs.gnu.org
Subject: bug#65113: Emacs-29 and master csharp-mode with broken treesit
Date: Thu, 10 Aug 2023 12:05:51 +0300 [thread overview]
Message-ID: <834jl7jmhc.fsf@gnu.org> (raw)
In-Reply-To: <C8F2F900-FD50-4305-BFF4-EADA1A7A574F@thornhill.no> (message from Theodor Thornhill on Mon, 07 Aug 2023 07:46:05 +0200)
> Date: Mon, 07 Aug 2023 07:46:05 +0200
> From: Theodor Thornhill <theo@thornhill.no>
> CC: 65113@debbugs.gnu.org
Ping! Can we please have a patch that is backward-compatible?
> On 6 August 2023 17:36:47 CEST, Eli Zaretskii <eliz@gnu.org> wrote:
> >> From: J M <jean@tbm.email>
> >> Date: Sun, 6 Aug 2023 16:03:45 +0100
> >>
> >> Treesit is broken for csharp-mode in the latest version in master and emacs-29 and therefore does not provide syntax highlighting. 
> >>
> >> The latest grammar repository (https://github.com/tree-sitter/tree-sitter-c-sharp) has removed the keyword void_keyword.
> >>
> >> Please see attached the patch to resolve the issue.
> >
> >Thanks, but your patch will not work with the older version of the
> >grammar library, right? Is it possible to make a patch that will work
> >with both? Wed cannot rely on users having the latest grammar
> >versions, so a backward-compatible change is much more preferable.
>
> We've had some similar patches lately that you can use for inspiration.
>
> Thanks,
> Theo
>
next prev parent reply other threads:[~2023-08-10 9:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-06 15:03 bug#65113: Emacs-29 and master csharp-mode with broken treesit J M
2023-08-06 15:36 ` Eli Zaretskii
2023-08-07 5:46 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-08-10 9:05 ` Eli Zaretskii [this message]
2023-08-10 22:42 ` J M
2023-08-11 5:57 ` Eli Zaretskii
2023-08-12 7:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834jl7jmhc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65113@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=jean@tbm.email \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).