From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65206: 29.1; [windows][patch] build-deps-zips.py is broken and hard to maintain Date: Tue, 15 Aug 2023 19:01:53 +0300 Message-ID: <834jl09tvy.fsf@gnu.org> References: <83msyzhvpz.fsf@gnu.org> <837cpw9uq6.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20620"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65206@debbugs.gnu.org To: Corwin Brust Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 15 18:03:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVwVl-00053e-H1 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Aug 2023 18:03:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVwVd-0005MV-34; Tue, 15 Aug 2023 12:03:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVwVb-0005Ku-4x for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 12:03:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVwVa-0004tS-SM for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 12:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVwVa-0001h5-G6 for bug-gnu-emacs@gnu.org; Tue, 15 Aug 2023 12:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Aug 2023 16:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65206 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65206-submit@debbugs.gnu.org id=B65206.16921153226443 (code B ref 65206); Tue, 15 Aug 2023 16:03:02 +0000 Original-Received: (at 65206) by debbugs.gnu.org; 15 Aug 2023 16:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:36540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVwUb-0001fd-Ng for submit@debbugs.gnu.org; Tue, 15 Aug 2023 12:02:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVwUW-0001fH-MB for 65206@debbugs.gnu.org; Tue, 15 Aug 2023 12:02:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVwUR-0004h3-4W; Tue, 15 Aug 2023 12:01:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=QuGWuOQj72bVRXO3SyG4cEJNk0xazMrx0fc7bJvdpQ4=; b=Vbb2Op66pK+P ZImPfFAx/sekqr/c5aO6JuQ8RU4KPD/UAP/yIxNO7YKk7JVszDn7JDOtYa8Bfp3Q+TvTpSoGb4+Q6 N6ZEn8ty6Zx2zMCDJ1Cap3XR3P/74L6PmmrJY3zaAbDasGEmfOgkINU4LV+zuwC+z1C0qc1QL2deT YGrgvbs8oxv8mQEMiR01hgTbFJvkGWEyNF2P0aL4ZaT6Uz69CucaD/OoofWxqLx1XpCmeL4OTCAr4 46liNA7yH38EdjVHelx8zguSkSqi4cjjPPnL4M8VOYgCOfy/xLMnrmBf3RmgbMePrJhohd8qgE/oL FVnQojlOmiM4zPdyyXaD6A==; In-Reply-To: (message from Corwin Brust on Tue, 15 Aug 2023 10:53:55 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267507 Archived-At: > From: Corwin Brust > Date: Tue, 15 Aug 2023 10:53:55 -0500 > Cc: 65206@debbugs.gnu.org > > > Thanks. What I still don't think I understand is how do you make sure > > you have a full list of first-order dependencies? I understand that > > you mostly build on the "last good" list from previous release, but > > since the list grows from time to time, what is the procedure for > > finding the new dependencies, adding them to the list, and making sure > > they all are there? > > > > I'm asking because this is exactly where the procedure broke down when > > we added WebP image support in Emacs 29. > > The above quote from myself I retained is my best/only answer: > > I update the script as issues are reported or when I somehow otherwise > learn that changes are needed. I have no real process for this, and > nothing in the tooling is helping me with it, so far. OK, so here's a suggestion which might improve that crucial part: scan the list in dynamic-library-alist, on lisp/term/w32-win.el. Every dependency that is loaded dynamically (i.e., Emacs is not linked against it when it is built) must be in that list. So when we add dependencies, we add them there. I believe that given a full and complete lest of first-order dependencies, those which Emacs actually loads, all the higher-order dependencies can be found by following the MSYS2 pacman etc., is that right?