From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Fri, 22 Sep 2023 15:59:13 +0300 Message-ID: <834jjm749q.fsf@gnu.org> References: <878r919qfh.fsf@localhost> <72c93fb0-bf3e-3dad-69c0-2147cfa40f57@gutov.dev> <875y42xyex.fsf@localhost> <87zg1ewfc2.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6421"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 15:00:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjflP-0001RL-1F for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 15:00:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjflC-0003Nn-E5; Fri, 22 Sep 2023 08:59:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjflA-0003N7-Ps for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 08:59:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjflA-0000NI-Gs for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 08:59:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjflK-0005pm-OZ for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 09:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.169538756322343 (code B ref 66117); Fri, 22 Sep 2023 13:00:02 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 22 Sep 2023 12:59:23 +0000 Original-Received: from localhost ([127.0.0.1]:35617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjfkg-0005oI-R6 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 08:59:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjfkd-0005o4-P2 for 66117@debbugs.gnu.org; Fri, 22 Sep 2023 08:59:20 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjfkN-0000HC-Q5; Fri, 22 Sep 2023 08:59:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+rr61iBF2JzlG2dbBYIwCQ0cBOUI0iRqlOYlhCdm3ds=; b=CCYvOOB/xzI6 ui6TUEs2mUMMk4aix2VK/eoPdCcqtNUZ+DQE6+qqgt4aFIOInlHAy3RZ2Fh96YStsOV3JnQSsxOUo OERPAzAZxxF8Mwv/5A7gOZJ4iW5MigcdJEOEwAIDY+Vgy23bKGGYieBH9d/jJLqNHkHP7+TAC7NQa K5ChOxru+YsoDHk/JWevlIxdv+m1knocH8WoaTvRLaeIAXTmR+X761APDThwLK8LWA1/1Xi1niryX Zj7WP1BGuq8ic1QYVFHwJMoYbbBgP8dg4hsgTMES714fuw83jiPLdAreJ6CLfaHtAHf3+OX1eRDBb 35W4AKbcir44/FA/2KOeuQ==; In-Reply-To: <87zg1ewfc2.fsf@localhost> (message from Ihor Radchenko on Fri, 22 Sep 2023 15:41:01 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271089 Archived-At: > Cc: 66117@debbugs.gnu.org > From: Ihor Radchenko > Date: Fri, 22 Sep 2023 15:41:01 +0300 > > Will it be acceptable to implement the cache using variable watchers? I don't like us using variable watchers for such stuff. Why cannot we just cache the correspondence between files and buffers in some hash-table? > The regression might happen when the number of buffers is small - > when hash tables become slower compared to simple list lookup. > But in such scenario, we will be talking about very small absolute > runtimes anyway, so it should probably not matter in practice. Alternatively, only create the hash-table when the number of buffers exceeds some threshold.